vendor AWS Go SDK

[BenTheElder]

xref: #6086

[BenTheElder]

/cc @chrislovecnm
I think this should work.

[chrislovecnm]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, chrislovecnm

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

• OWNERS [BenTheElder]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[fejta]

Nothing uses this. It should not be in test-infra

[chrislovecnm]

@fejta not yet but soon #6113

[chrislovecnm]

Also this uses the library and is not vendorred

[chrislovecnm]

https://github.com/kubernetes/test-infra/blob/master/jenkins/aws-janitor/main.go

[BenTheElder]

@fejta the boskos AWS-janitor does, we were explicitly telling dep not to vendor this before to side step it for some reason, and @chrislovecnm was planning to use it anyhow.

I checked in with @cblecker who authored the dep PR ignoring this library and he seemed to think the only reason it wasn't vendored before was the size. It seemed reasonable to actually vendor this along with our other dependencies..

test-infra/jenkins/aws-janitor/main.go

Lines 29 to 36 in 27a6969

	"github.com/aws/aws-sdk-go/aws"
	"github.com/aws/aws-sdk-go/aws/awserr"
	"github.com/aws/aws-sdk-go/aws/session"
	"github.com/aws/aws-sdk-go/service/autoscaling"
	"github.com/aws/aws-sdk-go/service/ec2"
	"github.com/aws/aws-sdk-go/service/iam"
	"github.com/aws/aws-sdk-go/service/s3"
	"github.com/golang/glog"

[BenTheElder]

To further clarify this PR is:

• remove the constraint to NOT vendor it in Gopkg.toml here:
  https://github.com/kubernetes/test-infra/pull/6101/files#diff-836546cc53507f6b2d581088903b1785

-# Ignore AWS SDK used by jenkins/aws-janitor
-ignored = ["github.com/aws/aws-sdk-go*"]
-

• run dep ensure
• run hack/update-bazel.sh

[cblecker]

@BenTheElder Did you do a dep prune in there too?

[BenTheElder]

I'm not certain. I think so but I don't have any record one way or the other.

…

On Sun, Jan 7, 2018 at 9:15 AM, Christoph Blecker ***@***.***> wrote: @BenTheElder <https://github.com/bentheelder> Did you do a dep prune in there too? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6101 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA4BqwCatmD20qUHyVv4NUP2HKJ2h9g3ks5tIPu1gaJpZM4RN5Te> .