Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve deck caching #6395

Merged
merged 1 commit into from
Jan 23, 2018
Merged

improve deck caching #6395

merged 1 commit into from
Jan 23, 2018

Conversation

BenTheElder
Copy link
Member

This should make deck allow static content to be cached with last-modified validation and disable all caching on dynamic endpoints.

/area prow

@k8s-ci-robot k8s-ci-robot added area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 23, 2018
@stevekuznetsov
Copy link
Contributor

Other than formatting and the yuck that is browser compat

/lgtm
/hold

In case @cjwagner wants to look

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jan 23, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, stevekuznetsov

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@cjwagner
Copy link
Member

LGTM too
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 23, 2018
@BenTheElder
Copy link
Member Author

Cherry pick snowflake Xref #6398
/retest

@k8s-ci-robot k8s-ci-robot merged commit dbee411 into kubernetes:master Jan 23, 2018
@BenTheElder BenTheElder deleted the caching-is-hard branch January 24, 2018 01:07
@xrstf xrstf mentioned this pull request Sep 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjwagner cjwagner Awaiting requested review from cjwagner

@0xmichalis 0xmichalis Awaiting requested review from 0xmichalis

Assignees

@stevekuznetsov stevekuznetsov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@BenTheElder @stevekuznetsov @k8s-ci-robot @cjwagner