Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set local fallback and correct domain #6673

Merged

Conversation

BenTheElder
Copy link
Member

  • jobs run in test-pods but the bazel cache is in default, correct the cache URL
  • also set local fallback so if the cache is unavailable the job doesn't fail..

/area bazel

@k8s-ci-robot k8s-ci-robot added area/bazel cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 6, 2018
@BenTheElder BenTheElder requested review from krzyzacy and ixdy February 6, 2018 22:25
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 6, 2018
Copy link
Member

@krzyzacy krzyzacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 6, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, krzyzacy

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:
  • OWNERS [BenTheElder,krzyzacy]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@ixdy
Copy link
Member

ixdy commented Feb 6, 2018

is default referring to the namespace? if so, why don't we put the bazel cache in its own namespace?

@BenTheElder
Copy link
Member Author

is default referring to the namespace? if so, why don't we put the bazel cache in its own namespace?

It is, and uh, it seemed un-necessary? everything else running in the build cluster is either kube-system or test-pods. We could move it to a namespace but I'm not sure what we gain from that really. It just makes your kubectl calls longer if you aren't using RBAC :+)

@BenTheElder
Copy link
Member Author

FWIW the Prow services cluster uses all default namespace with URLS like http://tide/

@BenTheElder
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 6, 2018
@BenTheElder
Copy link
Member Author

/woof
/joke

@k8s-ci-robot
Copy link
Contributor

@BenTheElder: dog image

In response to this:

/woof
/joke

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@BenTheElder: How many optometrists does it take to change a light bulb? 1 or 2? 1... or 2?

In response to this:

/woof
/joke

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot merged commit 6692fb6 into kubernetes:master Feb 6, 2018
@BenTheElder BenTheElder deleted the fix-bazel-remote-cache-options branch February 6, 2018 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/bazel cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants