Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix create_bazel_cache_rcs.sh #6685

Merged
merged 1 commit into from
Feb 7, 2018
Merged

fix create_bazel_cache_rcs.sh #6685

merged 1 commit into from
Feb 7, 2018

Conversation

BenTheElder
Copy link
Member

In #6682 build was left out from the --experimental_remote_spawn_cache line after switching
to this from the previous caching args 🤦‍♂️

/area this-is-why-we-have-presubmits
/area bazel
/area jobs
/shrug

@k8s-ci-robot k8s-ci-robot added ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯ area/bazel area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 7, 2018
@BenTheElder
Copy link
Member Author

/assign @krzyzacy @ixdy

@BenTheElder
Copy link
Member Author

@krzyzacy can we get a /facepalm to go with /shrug? >.<

@ixdy
Copy link
Member

ixdy commented Feb 7, 2018

/lgtm
/meow
/woof

@k8s-ci-robot
Copy link
Contributor

@ixdy: dog image

In response to this:

/lgtm
/meow
/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@ixdy: cat image

In response to this:

/lgtm
/meow
/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, ixdy

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@BenTheElder
Copy link
Member Author

BenTheElder commented Feb 7, 2018 via email

@k8s-ci-robot k8s-ci-robot merged commit 78f33a2 into kubernetes:master Feb 7, 2018
@BenTheElder BenTheElder deleted the follow-up-6682 branch February 7, 2018 04:35
@BenTheElder BenTheElder mentioned this pull request Feb 13, 2018
Closed
12 tasks
@BenTheElder BenTheElder added the area/greenhouse Issues or PRs related to code in /greenhouse (our remote bazel cache) label Sep 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@krzyzacy krzyzacy

@ixdy ixdy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/bazel area/greenhouse Issues or PRs related to code in /greenhouse (our remote bazel cache) area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BenTheElder @ixdy @k8s-ci-robot @krzyzacy