-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable golint and trigger plugins for kubernetes-sig-testing/frameworks #6934
Enable golint and trigger plugins for kubernetes-sig-testing/frameworks #6934
Conversation
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cjwagner, jamesjoshuahill The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jamesjoshuahill: Updated the plugins configmap In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@@ -300,6 +300,7 @@ plugins: | |||
- cat | |||
- cla | |||
- dog | |||
- golint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't the lint plugin globally available now? @cjwagner
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will enable it for the entire kubernetes-sig-testing org if that is what you mean, but that seems fine to me.
If you are asking if the golint plugin gets webhooks for all repos without having to be explicitly enabled, we don't have any mechanism for plugins to do that AFAIK.
Thanks @cjwagner for merging, thanks @BenTheElder for double-checking/reviewing! Shouldn't enabling the |
@hoegaarden you did trigger it, but you've got reporting disabled. from http://gcsweb.k8s.io/gcs/kubernetes-jenkins/pr-logs/directory/pull-frameworks-test/ it appears that the job failed once or twice without posting logs. You can check for your job after triggering at https://prow.k8s.io/, though this only holds recent jobs that have not been GCed from the cluster. Pod logs are viewable there. |
Following #6902
triggers
plugin to enable the/test
commandgolint
plugin because the repo is mostly golang