Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable golint and trigger plugins for kubernetes-sig-testing/frameworks #6934

Merged
merged 1 commit into from
Feb 22, 2018

Conversation

jamesjoshuahill
Copy link
Contributor

Following #6902

  • enable triggers plugin to enable the /test command
  • enable golint plugin because the repo is mostly golang

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 22, 2018
@hoegaarden
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 22, 2018
Copy link
Member

@cjwagner cjwagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 22, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjwagner, jamesjoshuahill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2018
@k8s-ci-robot k8s-ci-robot merged commit 593e8a1 into kubernetes:master Feb 22, 2018
@k8s-ci-robot
Copy link
Contributor

@jamesjoshuahill: Updated the plugins configmap

In response to this:

Following #6902

  • enable triggers plugin to enable the /test command
  • enable golint plugin because the repo is mostly golang

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@@ -300,6 +300,7 @@ plugins:
- cat
- cla
- dog
- golint
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't the lint plugin globally available now? @cjwagner

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will enable it for the entire kubernetes-sig-testing org if that is what you mean, but that seems fine to me.

If you are asking if the golint plugin gets webhooks for all repos without having to be explicitly enabled, we don't have any mechanism for plugins to do that AFAIK.

@hoegaarden
Copy link
Contributor

Thanks @cjwagner for merging, thanks @BenTheElder for double-checking/reviewing!

Shouldn't enabling the trigger plugin (this PR) and adding a trigger RE (in the other PR) allow me to trigger a test with a comment on a PR like here. Is there still some configuration missing? Where could I check for logs or so?

@BenTheElder
Copy link
Member

@hoegaarden you did trigger it, but you've got reporting disabled. from http://gcsweb.k8s.io/gcs/kubernetes-jenkins/pr-logs/directory/pull-frameworks-test/ it appears that the job failed once or twice without posting logs. You can check for your job after triggering at https://prow.k8s.io/, though this only holds recent jobs that have not been GCed from the cluster. Pod logs are viewable there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants