Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove test jobs for alpha.kubernetes.io/nvidia-gpu. #7539

Merged

Conversation

rohitagarwal003
Copy link
Member

Support for it was removed in kubernetes/kubernetes#61498

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 3, 2018
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 3, 2018
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, mindprince

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 3, 2018
@rohitagarwal003
Copy link
Member Author

Currently this job runs for 1.9, 1.10 and master.

This PR removes support for master.

When beta and stable1 pointers update, we should remove the old versions of this job instead of pointing it to 1.11.

@BenTheElder
Copy link
Member

When beta and stable1 pointers update, we should remove the old versions of this job instead of pointing it to 1.11.

cc @krzyzacy

@k8s-ci-robot k8s-ci-robot merged commit 32c028c into kubernetes:master Apr 3, 2018
@k8s-ci-robot
Copy link
Contributor

@mindprince: Updated the config configmap

In response to this:

Support for it was removed in kubernetes/kubernetes#61498

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rohitagarwal003
Copy link
Member Author

When beta and stable1 pointers update, we should remove the old versions of this job instead of pointing it to 1.11.

Note that this is only true for ci-kubernetes-e2e-gce-gpu* jobs and not for ci-kubernetes-e2e-gce-device-plugin-gpu* jobs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants