prow: enable stage plugin for k/features and k/sig-release

[nikhita]

Fixes #8315
Follow up to #8335

This enables the stage plugin for the k/features and k/sig-release repos.

/assign fejta cblecker

[nikhita]

I think the tests should pass once the stage plugin is added in #8335.

Adding an explicit hold until it is merged.
/hold

[nikhita]

/area prow

[nikhita]

added for sig-release as well, as per #8335 (comment)

[fejta]

This cannot be in the same PR as the plugins.yaml change. It belongs in the PR that creates the plugin.

After we merge the prow/hook/plugins.go change we will need to cut and deploy a new prow release, after which time we can make the plugins.yaml change to enable it.

[nikhita]

👍

[nikhita]

fixed.

[fejta]

/lgtm
/hold

Please wait until a prow bump after #8335 merges

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta, nikhita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• prow/OWNERS [fejta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[fejta]

Hey! Looks like we test for this.

exec ${PAGER:-/usr/bin/less} "$0" || exit 1
Executing tests from //prow/cmd/hook:go_default_test
-----------------------------------------------------------------------------
--- FAIL: TestPlugins (0.03s)
	main_test.go:29: Could not load plugins: invalid plugin configuration:
			unknown plugin: stage
			unknown plugin: stage.
FAIL

If we were really clever we would make this read the hook tag in prow/cluster/hook_deployment.yaml, check out that test-infra commit and run the test there.

We can just wait till the other PR merges and /retest to fix

[justaugustus]

/hold cancel
/retest

[nikhita]

/hold

I think we still need to bump prow.

[justaugustus]

Hey @nikhita, I think based on the original test failure above, tests here would continue to fail if prow hadn't integrated the new stage plugin. Since we're all green, I'm going to pull the hold.

/hold cancel

[k8s-ci-robot]

@nikhita: Updated the plugins configmap from file prow/plugins.yaml

In response to this:

Fixes #8315
Follow up to #8335

This enables the stage plugin for the k/features and k/sig-release repos.

/assign fejta cblecker

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[nikhita]

kubernetes/enhancements#571 (comment) :(

[nikhita]

I think we still need a prow bump for this to work.

test-infra/prow/cluster/hook_deployment.yaml

Line 36 in 6616384

image: gcr.io/k8s-prow/hook:v20180608-68f2851db

[fejta]

Correct, we still need to bump prow

[fejta]

tests here would continue to fail if prow hadn't integrated the new stage plugin

@justaugustus unfortunately it just means the new stage plugin has merged into master. Doesn't necessarily mean a new prow has been deployed yet.

[justaugustus]

@fejta I see. Is it a function of test-infra to bump prow or can a contributor submit a PR to do this as well?
There are instructions in the top-level of prow/, I'm just wondering if you need magic powers to use them.

[justaugustus]

kubernetes/enhancements#571 (comment)

It's alive! Thanks for your help @nikhita & @fejta!

[fejta]

go.k8s.io/oncall has to deploy new versions of prow (which happened this afternoon)