-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure set.Equal() compares the two set lengths #286
Conversation
set.Equal() currently checks the length of the owning set against itself, so a.Equal(b) returns true if a is a superset of b, with no further restriction. This fixes the length check and adds unit tests to catch this case. Signed-off-by: Stephen Kitt <skitt@redhat.com>
/kind bug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: logicalhan, skitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
See kubernetes/utils#286 for details. Signed-off-by: Stephen Kitt <skitt@redhat.com>
See kubernetes/utils#286 for details. Signed-off-by: Stephen Kitt <skitt@redhat.com>
See kubernetes/utils#286 for details. Signed-off-by: Stephen Kitt <skitt@redhat.com>
See kubernetes/utils#286 for details. Signed-off-by: Stephen Kitt <skitt@redhat.com>
See kubernetes/utils#286 for details. Signed-off-by: Stephen Kitt <skitt@redhat.com>
See kubernetes/utils#286 for details. Signed-off-by: Stephen Kitt <skitt@redhat.com>
See kubernetes/utils#286 for details. Signed-off-by: Stephen Kitt <skitt@redhat.com>
See kubernetes/utils#286 for details. Signed-off-by: Stephen Kitt <skitt@redhat.com>
See kubernetes/utils#286 for details. Signed-off-by: Stephen Kitt <skitt@redhat.com>
See kubernetes/utils#286 for details. Signed-off-by: Stephen Kitt <skitt@redhat.com>
What type of PR is this?
/kind bug
What this PR does / why we need it:
set.Equal() currently checks the length of the owning set against itself, so a.Equal(b) returns true if a is a superset of b, with no further restriction.
This fixes the length check and adds unit tests to catch this case.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: