-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transfer go get to go install #290
Transfer go get to go install #290
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments.
Once resolved, please run the hack/
scripts locally once to ensure things are good.
@nitishfy after resolving the last comment, please squash commits and we should be good to go here :) |
f5cc43d
to
8a6db1c
Compare
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/assign @dims
For approval
Signed-off-by: NitishKumar06 <justnitish06@gmail.com>
Sorry for the delay, this PR is ready for the next set of review. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, MadhavJivrajani, nitishfy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
What this PR does / why we need it:
go get
has been deprecated in Go for a few releases: https://go.dev/doc/go-get-install-deprecationhack/
. A few of them still usego get
I think, and we’re using go1.18 in the repo which should havego get
deprecated.Which issue(s) this PR fixes:
Fixes # N/A
Special notes for your reviewer:
N/A
Release note:
N/A