Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multi-listener test for HTTP #314

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Add multi-listener test for HTTP #314

merged 1 commit into from
Jul 11, 2024

Conversation

thockin
Copy link
Member

@thockin thockin commented Jul 11, 2024 •
edited

I forgot to followup on this question, so I just did it myself. :)

/kind test

Release note:

NONE

@thockin thockin requested a review from aroradaman July 11, 2024 00:17
@k8s-ci-robot
Copy link
Contributor

@thockin: The label(s) kind/test cannot be applied, because the repository doesn't have them.

In response to this:

I forgot to followup on this question, so I just solved it myself. :)

/kind test

Release note:

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 11, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 11, 2024
@aroradaman
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 11, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aroradaman, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 18e509b into kubernetes:master Jul 11, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aroradaman aroradaman aroradaman approved these changes

@dashpole dashpole Awaiting requested review from dashpole

@mengqiy mengqiy Awaiting requested review from mengqiy

Assignees

@danwinship danwinship

@aroradaman aroradaman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@thockin @k8s-ci-robot @aroradaman @danwinship