-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow switching website between “light mode” and “dark mode” #25061
Comments
/retitle Allow switching website between “light mode” and “dark mode” /kind feature |
@HBDUDE interesting idea. If this gets a few 👍 reactions we'll be happy to accept it as a feature for the backlog. |
It would be great to have such an option. Since reading the documentation, the dark mode helps in reading for longer period of time. |
It would save energy, too. |
Just in curiosity, because I’m new to open source software, but does that mean anyone can potentially contribute? Say if someone wanted to build a dark mode out and then submitted it for review, would that be something someone could do? |
Indeed, you can and it will be much appreciated. I already started working on it. If you want to coordinate and help, let me know. I also recommend checking out the project and reading the Readme, you will see links to Slack and Mailinglist there. |
Ok, that’s really cool to know. Im not extremely experienced as a dev yet, and so I don’t know if I’d be of much use, but I’d love to check out the code and see how it goes. |
/priority backlog |
+1 |
Please someone provide location of central SASS (or similar) file. I asked in Slack, w/o result.
|
@stevek-pro this is a backlog priority issue. SIG Docs has a really chunky amount of work that we've triaged as more valuable, so it's likely that this will move forward specifically when someone who wants to see this specific improvement land picks it up. If we don't see any movement within a few months, we have a bot that would close the feature request. |
See https://stuffandnonsense.co.uk/blog/redesigning-your-product-and-website-for-dark-mode for a CSS approach towards implementing this. |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
Thanks. I will look into it. |
/remove-lifecycle rotten |
Any implementation of this needs to work for diagrams and other graphics, as well as text. We don't want to have people who prefer dark mode missing out on being able to see what a diagram says. |
Sorry I did not follow up earlier, but since I discovered dark reader plugin, I am in no need of this feature anymore. |
As well as using CSS, if we find we need JavaScript for some aspect then that's also feasible, eg https://flaviocopes.com/javascript-detect-dark-mode/ |
Duplicated by #39263 |
I don't see any dark mode button on the kubernetes website, so i suppose this issue is still not resolved? so can I work on this? I think I can help. |
/assign |
can someone help me locate the main css file which is relevant to make a change in? |
This is SCSS, not CSS. If you're planning to work on #37444, try selecting |
Hey @KhushPatibandha, I see that you're working on this feature. Would you like to collaborate on a PR? |
Also see #43084 |
Duplicated by #44159 |
Help is welcome. Please consider working on #37444 first. |
Another duplicate request #44323 |
Help is welcome. Please consider working on #37444 first. |
In the long term, we might want to consider aligning with Docsy since it now supports Dark Mode (announcement here). |
Needs a dark mode for enhanced accessibility.
The text was updated successfully, but these errors were encountered: