Add optional dark mode to API docs #43084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/hold
k8s-ci-robot
added
size/M
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 9f288fbc7fa58b0197bc3e4e9c1f5b56678c152f
|
xrstf
force-pushed
the
dark-mode-apidocs
branch
from
4b0cc8d
to
1c1bfa6
Compare
k8s-ci-robot
removed
the
lgtm
k8s-ci-robot
added
size/L
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 063f80f8801691afcfb6e041cfa6df87debae624
|
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the necessary CSS/JS code to make the dark mode for the API docs work. This is the sister PR to kubernetes-sigs/reference-docs#337 and kubernetes-sigs/reference-docs#338
The dark mode would look like this, using default Bootstrap colors:
/hold
This should only be merged if and when the sister PR is merged.
I also adjusted the font and some colors to better match the Kubernetes website (at least in light mode).