fine-tune apidocs markup for dark mode #338
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the result of working a bit more on the dark mode for the apidocs. I had to extend the markup a bit, now at least the result is now pretty:
I adopted the font that is used on kubernetes.io, plus the colors in light mode were adjusted a bit to better match the Kubernetes website.
The markup is now also setup for an CSS-only automatic dark mode, which avoids the previous flash-of-white before the JS kicked in and applied the theme-dark class.
I also renamed the scroll-apiref.js, since the file is not just responsible for the scrolling behaviour, but also the dark mode toggler. I hope this won't cause issues when the website repo PR is eventually merged.