Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace all references to https://storage.googleapis.com/kubernetes-release with https://dl.k8s.io #41069

Closed
BenTheElder opened this issue May 10, 2023 · 9 comments · Fixed by #41072, #41075, #41076, #41077 or #41079
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@BenTheElder
Copy link
Member

This is a Bug Report

Problem:

There are still references to https://storage.googleapis.com/kubernetes-release instead of https://dl.k8s.io

dl.k8s.io is the correct advertised download host and will eventually move to be fastly shielding a fully community-owned bucket

ref: kubernetes/k8s.io#2396

Proposed Solution:

Replace https://storage.googleapis.com/kubernetes-release with https://dl.k8s.io

Also replace any gs://kubernetes-release references with using https://dl.k8s.io if applicable.

Page to Update:

Assorted https://cs.k8s.io/?q=%2Fkubernetes-release&i=nope&files=&excludeFiles=&repos=kubernetes/website
e.g. tasks/tools/install-kubectl.md, setup/production-environment/tools/kubeadm/install-kubeadm.md

@BenTheElder BenTheElder added the kind/bug Categorizes issue or PR as related to a bug. label May 10, 2023
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label May 10, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

SIG Docs takes a lead on issue triage for this website, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pranav-pandey0804
Copy link

/assign

@pranav-pandey0804
Copy link

sorry @pranav-pandey0804, i had fixed this

hi @9bany Not a problem, didn't see anyone assigned to this issue.
I am unassigning myself and assigning it to you.

/unassign

@9bany
Copy link
Contributor

9bany commented May 11, 2023

/assign

@shurup
Copy link
Member

shurup commented May 11, 2023

Hi, @9bany! I found a small issue with your proposed changes regarding one of the URLs, which is mentioned twice in the install-kubectl.md file.

While curl -s https://storage.googleapis.com/kubernetes-release/release/stable.txt returns v1.27.1 as expected, I am getting an nginx-rendered HTML page saying 302 Found for the new command (curl -s https://dl.k8s.io/release/stable.txt) instead.

As I understand, it happens due to the redirect configured on the new web server. Thus, curl -LS https://dl.k8s.io/release/stable.txt works fine for me (it returns v1.27.1 as expected).

@9bany
Copy link
Contributor

9bany commented May 11, 2023

i see
Let me update it, thanks your work @shurup

@9bany
Copy link
Contributor

9bany commented May 11, 2023

Just done, please review all of PRs @-approvers

@BenTheElder
Copy link
Member Author

Thanks!

@BenTheElder
Copy link
Member Author

And yes: These will need curl -L to follow redirects, in the future the tentative plan is it will redirect to a CDN in front of a different bucket created in a fully project / SIG-K8s-Infra controlled GCP or AWS account.

I would recommend -L for downloading with curl more generally, even in docs / usage for other hosts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment