Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ko] replace all references to storage.googleapis.com/kubernetes-release with dl.k8s.io #41078

Conversation

9bany
Copy link
Contributor

@9bany 9bany commented May 11, 2023

fixes: #41069

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 11, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jihoon-seo for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from ianychoi May 11, 2023 09:51
@k8s-ci-robot k8s-ci-robot added the language/ko Issues or PRs related to Korean language label May 11, 2023
@k8s-ci-robot k8s-ci-robot requested a review from seokho-son May 11, 2023 09:51
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 11, 2023
@9bany 9bany changed the title [ko] replace all references to https://storage.googleapis.com/kubernetes-release to https://dl.k8s.ioadd log [ko] replace all references to storage.googleapis.com/kubernetes-release with dl.k8s.io May 11, 2023
@netlify
Copy link

netlify bot commented May 11, 2023

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 36cf98b
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/645cbab868a39100086e08f3
😎 Deploy Preview https://deploy-preview-41078--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@rjsadow
Copy link
Contributor

rjsadow commented May 17, 2023

/assign @gochist

@gochist
Copy link
Member

gochist commented May 19, 2023

Hello @9bany 👋! It was assigned to @jongwooo in issue #38458.

As you can see in issue #38458, Korean localization uses a working branch to keep up with upstream changes from the previous working branch. Currently it is dev-1.26-ko.1 .

In order to prevent conflicts when merging the working branch into the main branch in the future, it seems necessary to coordinate with @9bany and @jongwooo.

I suggest to @9bany to change the base branch of this PR from main to dev-1.26-ko.1.

@9bany 9bany changed the base branch from main to dev-1.26-ko.1 May 22, 2023 07:41
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 22, 2023
@9bany 9bany changed the base branch from dev-1.26-ko.1 to main May 22, 2023 07:41
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 22, 2023
@9bany
Copy link
Contributor Author

9bany commented May 22, 2023

Hello @gochist, i don't have any idea how can i create a new branch base from dev-1.26-ko.1
as you can see, i was change base from main to dev-1.26-ko.1, but it too big PR

@rjsadow
Copy link
Contributor

rjsadow commented May 22, 2023

Hey @9bany I think what you're going to need to do is:

  1. Ensure you have all the latest branches available in your repo. git pull upstream
  2. Checkout dev-1.26-ko.1
  3. Cherry pick your commit from your main to dev-1.26-ko.1. git cherry-pick 36cf98b08515f204875338a4d5ff534bc17cb153
  4. Re push. git push .... --force
  5. Update the target branch to also be dev-1.26-ko.1

@9bany
Copy link
Contributor Author

9bany commented May 23, 2023

I was open new pull request in here #41078
jus close this

@9bany 9bany closed this May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replace all references to https://storage.googleapis.com/kubernetes-release with https://dl.k8s.io
4 participants