Document nodelease feature #10699

wangzhen127 · 2018-10-22T19:43:28Z

This PR documents the node lease feature. This is part of KEP-0009, feature #589 and issue #14733.

wangzhen127 · 2018-10-22T19:48:24Z

/sig node
/milestone v1.13
/cc @wojtek-t
/cc @yujuhong
/cc @tfogo

wojtek-t

From purely technical POV it looks fine, but we need more tech-writing-oriented review on that.

content/en/docs/concepts/architecture/nodes.md

wangzhen127 · 2018-10-26T18:23:30Z

/assign @tfogo

tfogo · 2018-11-01T20:57:01Z

content/en/docs/concepts/architecture/nodes.md

@@ -160,6 +160,16 @@ to be unreachable. (The default timeouts are 40s to start reporting
 ConditionUnknown and 5m after that to start evicting pods.) The node controller
 checks the state of each node every `--node-monitor-period` seconds.

+In versions of Kubernetes prior to 1.13, NodeStatus is the heartbeat from the
+node. Starting from Kubernetes 1.13, node lease feature is introduced, so that


Can you add a bit more information about what the node lease is? Perhaps linking to the KEP might be helpful too.

Oh can you also add what state (alpha/beta/etc) the node lease feature is in? Thanks!

tfogo · 2018-11-01T20:57:35Z

content/en/docs/concepts/architecture/nodes.md

+In versions of Kubernetes prior to 1.13, NodeStatus is the heartbeat from the
+node. Starting from Kubernetes 1.13, node lease feature is introduced, so that
+both NodeStatus and node lease are treated as heartbeats. When node lease
+feature is enabled, node leases are renewed frequently while NodeStatus is


Is there a feature flag to enable node leases? If so, please add information on that flag.

tfogo · 2018-11-01T20:59:25Z

Thanks @wangzhen127, I left a couple of suggestions.

wangzhen127

Thanks for the review! Updated and PTAL.

/hold
Holding the PR until the kubernetes side PRs are merged first (kubernetes/kubernetes#69753 and kubernetes/kubernetes#70034).

wangzhen127 · 2018-11-05T21:58:45Z

content/en/docs/concepts/architecture/nodes.md

@@ -160,6 +160,16 @@ to be unreachable. (The default timeouts are 40s to start reporting
 ConditionUnknown and 5m after that to start evicting pods.) The node controller
 checks the state of each node every `--node-monitor-period` seconds.

+In versions of Kubernetes prior to 1.13, NodeStatus is the heartbeat from the
+node. Starting from Kubernetes 1.13, node lease feature is introduced, so that


wangzhen127 · 2018-11-05T22:01:09Z

content/en/docs/concepts/architecture/nodes.md

+In versions of Kubernetes prior to 1.13, NodeStatus is the heartbeat from the
+node. Starting from Kubernetes 1.13, node lease feature is introduced, so that
+both NodeStatus and node lease are treated as heartbeats. When node lease
+feature is enabled, node leases are renewed frequently while NodeStatus is


wangzhen127 · 2018-11-10T07:27:14Z

/hold cancel
Code is complete for this feature. @tfogo, can you take another look at this documentation PR?

wangzhen127 · 2018-11-13T17:47:48Z

ping @tfogo :)

tfogo · 2018-11-19T16:42:26Z

/approve
/lgtm

k8s-ci-robot · 2018-11-19T16:42:34Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tfogo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~content/en/OWNERS~~ [tfogo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* Update metadata.generation behaviour for custom resources (#10705) * update docs promoting plugins to beta (#10796) * docs update to promote TaintBasedEvictions to beta (#10765) * First Korean l10n work for dev-1.13 (#10719) * Update outdated l10n(ko) contents (#10689) fixes #10686 * Translate concepts/overview/what-is-kubernetes in Korean (#10690) * Translate concepts/overview/what-is-kubernetes in Korean * Feedback from ClaudiaJKang * Translate concepts/overview/components in Korean (#10882) * Translate concepts/overview/components in Korean #10717 * Translate concepts/overview/components in Korean * Translate concepts/overview/components in Korean * Apply Korean glossary: 서비스 어카운트 * Translate concepts/overview/kubernetes-api in Korean (#10773) * Translate concepts/overview/kubernetes-api in Korean * Applied feedback from ianychoi * kubeadm: update the configuration docs to v1beta1 (#10959) * kubeadm: add small v1beta1 related updates (#10988) * ADD content/zh/docs/reference/setup-tools/kubeadm/kubeadm.md (#11031) * ADD content/zh/docs/reference/setup-tools/kubeadm/kubeadm.md * ADD content/zh/docs/reference/setup-tools/kubeadm/generated/kubeadm_init.md * Update content/zh/docs/reference/setup-tools/kubeadm/kubeadm.md Accepted Co-Authored-By: YouthLab <tsui@highyouth.com> * do not change 'master' or 'worker' nodes to '主从' * Doc updates for volume scheduling GA (#10743) * Doc updates for volume scheduling GA * Make trivial change to kick build * Document nodelease feature (#10699) * advanced audit doc for ModeBlockingStrict (#10203) * Rename EncryptionConfig to EncryptionConfiguration (#11080) EncryptionConfig was renamed to EncryptedConfiguration and added to the `apiserver.config.k8s.io` API group in Kubernetes 1.13. The feature was previously in alpha and was not handling versions properly, which lead to an originally unnoticed `v1` in the docs. * content/zh/docs/reference/setup-tools/kubeadm/kubeadm-init.md * trsanlate create-cluster-kubeadm.md to chinese (#11041) * trsanlate create-cluster-kubeadm.md to chinese * Update create-cluster-kubeadm.md * update the feature stage in v1.13 (#11307) * update new feature gates to document (#11295) * refresh controller role list on rbac description page (#11290) * node labeling restriction docs (#10944) * Update 1.13 docs for CSI GA (#10893) * dynamic audit documentation (#9947) * adds dynamic audit documentation * Copyedit for clarity See also inline question/s * Fix feature state shortcode * Update feature state * changes wording for dynamic audit flag behavior * Minor copyedit * fix dynamic audit yaml * adds api enablement command to dynamic audit docs * change ordering dynamic audit appears in * add references to dynamic audit in webhook backend * reword dynamic audit reference * updates stages field for audit sink object * changes audit sink api definition; rewords policy * kubeadm: remove kube-proxy workaround (#11162) * zh-trans content/en/docs/setup/independent/install-kubeadm.md (#11338) * zh-trans content/en/docs/setup/independent/install-kubeadm.md * Update install-kubeadm.md * Update dry run feature to beta (#11140) * vSphere volume raw block support doc update (#10932) * Add docs for Windows DNS configurations (#10036) * Update docs for fields allowed at root of CRD schema (#9973) * Add docs for Windows DNS configurations * add device monitoring documentation (#9945) * kubeadm: adds upgrade instructions for 1.13 (#11138) * kubeadm: adds upgrade instructions for 1.13 Signed-off-by: Chuck Ha <ha.chuck@gmail.com> * add minor copyedits Addressed a couple of copyedit comments a bit more cleanly. * kubeadm: add improvements to HA docs (#11094) * kubeadm: add information and diagrams for HA topologies * kubeadm: update HA doc with simplified steps * kubeadm: update HA doc with simplified steps * edit ha, add new topology topic, reorder by weight * troubleshoot markdown * fix more markdown, fix links * more markdown * more markdown * more markdown * changes after reviewer comments * add steps about Weave * update note about stacked topology * kubeadm external etcd HA upgrade 1.13 (#11364) * kubeadm external etcd HA upgrade 1.13 Signed-off-by: Ruben Orduz <rubenoz@gmail.com> * Update stacked controlplane steps * kubeadm cert documentation (#11093) * kubeadm certificate API and CSR documentation * copyedits * fix typo * PR for diff docs (#10789) * Empty commit against dev-1.13 for diff documentation * Complete Declarative maangement with diff commands * Second Korean l10n work for dev-1.13. (#11030) * Update outdated l10n(ko) contents (#10915) * Translate main menu for l10n(ko) docs (#10916) * Translate tasks/run-application/horizontal-pod-autoscale-walkthrough (#10980) * Translate content/ko/docs/concepts/overview/working-with-objects/kubernetes-object in Korean #11104 (#11332) * Pick-right-solution page translates into Korean. (#11340) * ko-trans: add jd/..., sap/..., ebay/..., homeoffice/... (#11336) * Translate concept/workloads/pods/pod-overview.md (#11092) Co-authored-by: June Yi <june.yi@samsung.com> Co-authored-by: Jesang Myung <jesang.myung@gmail.com> Co-authored-by: zerobig <38598117+zer0big@users.noreply.github.com> Co-authored-by: Claudia J.Kang <claudiajkang@gmail.com> Co-authored-by: lIuDuI <1693291525@qq.com> Co-authored-by: Woojin Na(Eddie) <cheapluv@gmail.com> * Rename encryption-at-rest related objects (#11059) EncryptionConfig was renamed to EncryptedConfiguration and added to the `apiserver.config.k8s.io` API group in Kubernetes 1.13. The feature was previously in alpha and was not handling versions properly, which lead to an originally unnoticed `v1` in the docs. Also, the `--experimental-encryption-provider-config` flag is now called just `--encryption-provider-config`. * Documenting FlexVolume Resize alpha feature. (#10097) * CR webhook conversion documentation (#10986) * CR Conversion * Addressing comments * Addressing more comments * Addressing even more comments * Addressing even^2 more comments * Remove references to etcd2 in v1.13 since support has been removed (#11414) * Remove etcd2 references as etcd2 is deprecated Link back to the v1.12 version of the etcd3 doc for the etcd2->etcd3 migration instructions. I updated the kube-apiserver reference manually, unsure if that is auto-generated somehow. The federation-apiserver can still potentially support etcd2 so I didn't touch that. * Remove outdated {master,node}.yaml files There are master/node yaml files that reference etcd2.service that are likely highly out of date. I couldn't find any docs that actually reference these templates so I removed them * Address review comments * Final Korean l10n work for dev-1.13 (#11440) * Update outdated l10n(ko) contents (#11425) fixes #11424 * Remove references to etcd2 in content/ko (#11416) * Resolve conflicts against master for /ko contents (#11438) * Fix unopened caution shortcode * kubeadm: update the reference docs for 1.13 (#10960) * docs update to promote TaintBasedEvictions to beta (#10765) * First Korean l10n work for dev-1.13 (#10719) * Update outdated l10n(ko) contents (#10689) fixes #10686 * Translate concepts/overview/what-is-kubernetes in Korean (#10690) * Translate concepts/overview/what-is-kubernetes in Korean * Feedback from ClaudiaJKang * Translate concepts/overview/components in Korean (#10882) * Translate concepts/overview/components in Korean #10717 * Translate concepts/overview/components in Korean * Translate concepts/overview/components in Korean * Apply Korean glossary: 서비스 어카운트 * Translate concepts/overview/kubernetes-api in Korean (#10773) * Translate concepts/overview/kubernetes-api in Korean * Applied feedback from ianychoi * kubeadm: update the configuration docs to v1beta1 (#10959) * kubeadm: add small v1beta1 related updates (#10988) * update new feature gates to document (#11295) * Update dry run feature to beta (#11140) * kubeadm: add improvements to HA docs (#11094) * kubeadm: add information and diagrams for HA topologies * kubeadm: update HA doc with simplified steps * kubeadm: update HA doc with simplified steps * edit ha, add new topology topic, reorder by weight * troubleshoot markdown * fix more markdown, fix links * more markdown * more markdown * more markdown * changes after reviewer comments * add steps about Weave * update note about stacked topology * kubeadm: update reference docs - add section about working with phases under kubeadm-init.md - update GA / beta status of features - kubeadm alpha phase was moved to kubeadm init phase - new commands were added under kubeadm alpha - included new CoreDNS usage examples * Generate components and tools reference * Add generated federation API Reference (#11491) * Add generated federation API Reference * Add front matter to federation reference * Remove whitespace from federation front matter * Remove more whitespace from federation front matter * Remove superfluous kubefed reference * Add frontmatter to generated kubefed reference * Fix kubefed reference page frontmatter * Generate kubectl reference docs 1.13 (#11487) * Generate kubectl reference docs 1.13 * Fix links in kubectl reference * Add 1.13 API reference (#11489) * Update config.toml (#11486) * Update config.toml Preparing for 1.13 release, updating the config.toml and dropping the 1.8 docs reference. * update dot releases and docsbranch typo * adding .Site. to Params.currentUrl (#11503) see #11502 for context * Add 1.13 Release notes (#11499)

tfogo added this to the 1.13 milestone Oct 22, 2018

kubernetes-docs-i18n-bot added the language/en Issues or PRs related to English language label Oct 22, 2018

k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 22, 2018

k8s-ci-robot requested review from caesarxuchao, dchen1107 and tfogo October 22, 2018 20:49

k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Oct 22, 2018

k8s-ci-robot requested review from wojtek-t and yujuhong October 22, 2018 20:52

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 22, 2018

wojtek-t reviewed Oct 24, 2018

View reviewed changes

content/en/docs/concepts/architecture/nodes.md Outdated Show resolved Hide resolved

wangzhen127 force-pushed the nodelease branch from 3a29eb1 to f5d47f2 Compare October 24, 2018 19:59

k8s-ci-robot assigned tfogo Oct 26, 2018

wangzhen127 mentioned this pull request Nov 1, 2018

Make periodic NodeStatus updates cheaper kubernetes/kubernetes#14733

Closed

tfogo suggested changes Nov 1, 2018

View reviewed changes

wangzhen127 force-pushed the nodelease branch from f5d47f2 to ce77a7c Compare November 5, 2018 22:10

wangzhen127 commented Nov 5, 2018

View reviewed changes

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 5, 2018

wangzhen127 mentioned this pull request Nov 8, 2018

Move frequent Kubelet heartbeats to Lease API kubernetes/enhancements#589

Closed

6 tasks

Document nodelease feature

2106140

wangzhen127 force-pushed the nodelease branch from ce77a7c to 2106140 Compare November 10, 2018 07:25

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 10, 2018

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 19, 2018

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2018

k8s-ci-robot merged commit e24a059 into kubernetes:dev-1.13 Nov 19, 2018

wangzhen127 deleted the nodelease branch November 19, 2018 16:54

tfogo pushed a commit that referenced this pull request Dec 1, 2018

Document nodelease feature (#10699)

0c53f2f

jimangel modified the milestones: 1.13, 1.14 Mar 16, 2019

jimangel mentioned this pull request Mar 16, 2019

Official 1.14 Release Docs #13174

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Document nodelease feature #10699

Document nodelease feature #10699

wangzhen127 commented Oct 22, 2018

wangzhen127 commented Oct 22, 2018

wojtek-t left a comment

wangzhen127 commented Oct 26, 2018

tfogo Nov 1, 2018

tfogo Nov 1, 2018

wangzhen127 Nov 5, 2018

tfogo Nov 1, 2018 •

edited

Loading

wangzhen127 Nov 5, 2018

tfogo commented Nov 1, 2018

wangzhen127 left a comment

wangzhen127 Nov 5, 2018

wangzhen127 Nov 5, 2018

wangzhen127 commented Nov 10, 2018

wangzhen127 commented Nov 13, 2018

tfogo commented Nov 19, 2018

k8s-ci-robot commented Nov 19, 2018

Document nodelease feature #10699

Document nodelease feature #10699

Conversation

wangzhen127 commented Oct 22, 2018

wangzhen127 commented Oct 22, 2018

wojtek-t left a comment

Choose a reason for hiding this comment

wangzhen127 commented Oct 26, 2018

tfogo Nov 1, 2018

Choose a reason for hiding this comment

tfogo Nov 1, 2018

Choose a reason for hiding this comment

wangzhen127 Nov 5, 2018

Choose a reason for hiding this comment

tfogo Nov 1, 2018 • edited Loading

Choose a reason for hiding this comment

wangzhen127 Nov 5, 2018

Choose a reason for hiding this comment

tfogo commented Nov 1, 2018

wangzhen127 left a comment

Choose a reason for hiding this comment

wangzhen127 Nov 5, 2018

Choose a reason for hiding this comment

wangzhen127 Nov 5, 2018

Choose a reason for hiding this comment

wangzhen127 commented Nov 10, 2018

wangzhen127 commented Nov 13, 2018

tfogo commented Nov 19, 2018

k8s-ci-robot commented Nov 19, 2018

tfogo Nov 1, 2018 •

edited

Loading