-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replaced deprecated 'kubectl run' for minikube setup #11113
Conversation
swapped kubectl run for kubectl create -f - against stable api
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Deploy preview for kubernetes-io-master-staging ready! Built with commit ff346cd https://deploy-preview-11113--kubernetes-io-master-staging.netlify.com |
Addition: kubernetes/kubernetes#71006 seems to change the behavior of |
@sluetze it looks as though this PR should retarget the |
/assign |
Hi @sluetze, I'm trying to get all PRs for 1.13 merged asap. Could you let me know what the status of this PR is? Thanks! |
Hi @tfogo @Bradamant3, sorry if I was not precise. so there are two possibilities:
apply only to dev-1.13 makes no sense since it fixes nothing. |
@tfogo I'll leave this one to you for final decision, but my inclination is to discard this PR since we're shipping 1.13 so soon. |
I agree, please discard this PR and make a new PR targeting |
swapped kubectl run for kubectl create -f - against stable api
fixes #10956