Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced deprecated 'kubectl run' for minikube setup #11113

Closed
wants to merge 1 commit into from

Conversation

sluetze
Copy link

@sluetze sluetze commented Nov 20, 2018

swapped kubectl run for kubectl create -f - against stable api

fixes #10956

swapped kubectl run for kubectl create -f - against stable api
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 20, 2018
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. language/en Issues or PRs related to English language labels Nov 20, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: stewart-yu

If they are not already assigned, you can assign the PR to them by writing /assign @stewart-yu in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit ff346cd

https://deploy-preview-11113--kubernetes-io-master-staging.netlify.com

@sluetze sluetze changed the title replaced deprecated 'kubectl run' replaced deprecated 'kubectl run' for minikube setup Nov 20, 2018
@sluetze
Copy link
Author

sluetze commented Nov 20, 2018

Addition: kubernetes/kubernetes#71006 seems to change the behavior of kubectl run for version v1.13 and supersedes the doc-change (at least vor v1.13)

@Bradamant3 Bradamant3 added this to the 1.13 milestone Nov 26, 2018
@Bradamant3
Copy link
Contributor

@sluetze it looks as though this PR should retarget the dev-1.13 branch, yes? If you could take care of it, that would be great. Thank you so much for your contribution!

@tfogo
Copy link
Contributor

tfogo commented Nov 27, 2018

/assign

@tfogo
Copy link
Contributor

tfogo commented Nov 27, 2018

Hi @sluetze, I'm trying to get all PRs for 1.13 merged asap. Could you let me know what the status of this PR is? Thanks!

@sluetze
Copy link
Author

sluetze commented Nov 28, 2018

Hi @tfogo @Bradamant3,

sorry if I was not precise.
This doc change is only relevant for 1.12, since in 1.12 #10956 exists (kubectl run calls api deployment/apps.v1beta1 which is deprecated ).
Due to the change in PR kubernetes/kubernetes#71006 the issue #10956 should not exist in 1.13 (kubectl run calls api apps/v1, [I did not test this, since i don't have a 1.13 cluster deployed atm])

so there are two possibilities:

  1. discard my PR, since this is only a temporary problem
  2. apply my PR to 1.12 (master) and file another PR to undo this PR for dev-1.13

apply only to dev-1.13 makes no sense since it fixes nothing.
apply to 1.12 (master) and dev-1.13 makes no sense, since the deployment with kubectl create -f - is more complex than with kubectl run

@Bradamant3
Copy link
Contributor

@tfogo I'll leave this one to you for final decision, but my inclination is to discard this PR since we're shipping 1.13 so soon.

@tfogo tfogo removed this from the 1.13 milestone Nov 29, 2018
@mdlinville
Copy link
Contributor

I agree, please discard this PR and make a new PR targeting release-1.12 if you are still interested in fixing this for that version.

@mdlinville mdlinville closed this Dec 12, 2018
@sluetze sluetze deleted the patch-1 branch January 3, 2019 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with k8s.io/docs/setup/minikube/
6 participants