Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubeadm external etcd HA upgrade 1.13 #11330

Closed
wants to merge 207 commits into from

Conversation

rdodev
Copy link
Contributor

@rdodev rdodev commented Nov 26, 2018

Signed-off-by: Ruben Orduz rubenoz@gmail.com

Document for upgrading kubernetes from 1.12 to 1.13 of HA control plane with HA external etcd via kubeadm.

/assign @timothysc

zacharysarah and others added 30 commits November 1, 2018 15:32
It was not clear where the yaml blob should be saved in. Added a single like that clears up what file to edit.
Clarify that the --vm-driver none option only works on a linux environment
Remove unintentional changes from a different branch

Correct English alias
* Modified into appropriate words

* Modified into appropriate words
* clean-up minikube toc

- clean-up minikube toc
- clean-up localkube link

* update sub-headers

* added link to kubeadm

- added link to kubeadm
- clean-up link to kubectl config set-context
* Update tutorial to work with Katacoda, No Install

* Update hello-minikube.md
* Revert "Update tutorial to work with Katacoda, No Install (kubernetes#10797)"

This reverts commit a0b97a3.

* Revert "clean-up minikube toc (kubernetes#10873)"

This reverts commit 18343eb.

* Revert "Tutorial cleanup: Delete K8s 101 and 201 (kubernetes#10786)"

This reverts commit e0168fd.

* Revert "fix word err in Disruption (kubernetes#10884)"

This reverts commit d01b76d.

* Revert "Fix typo (kubernetes#10877)"

This reverts commit 1551868.

* Revert "add note informing users of env var updates (kubernetes#10819)"

This reverts commit 795de19.

* Revert "Fix typo in word repositories (kubernetes#10883)"

This reverts commit 6d7f27e.

* Revert "Add i18n strings for Korean translation (kubernetes#10611)"

This reverts commit a9d8c54.

* Revert "Modified into appropriate words (kubernetes#10768)"

This reverts commit 7ebdd66.

* Revert "Update tools.md (kubernetes#10753)"

This reverts commit 2d8bc15.

* Revert "Enable reviews/approvers for localized site strings (kubernetes#10811)"

This reverts commit 81b2562.
* Update HAProxy ingress line

HAProxy Technologies offers support for the free available haproxy ingress controller

* Updated the haproxy wording from feedback

Updated the haproxy wording from feedback of @tengqm

* Remove doc artefacts
* Change existing admon blocks

* Fix includes issue
…rnetes#10891)

* add grpc load balancing with linkerd blog post

* remove date from filenames

I can follow instructions.

* update links with new date-less paths

* Update grpc-load-balancing-with-linkerd.md
Kubeernetes->Kubernetes

Typo fix: Kubernets->Kubernetes

Typo fix: Kubernets->Kubernetes
Note should not be code-formatted and command should be inside note
block.

Signed-off-by: Leah Hanson <lhanson@pivotal.io>
kubernetes#10294)

* Added feature-gates deprecation guidelines and policy as per discussion: SIG-architecture meeting

* Update deprecation-policy.md

Fixes and initial feedback incorporated.

* Removed unneeded sentence

Removed complicated sentence that is better phrased one sentence later.

* Incorporated feedback - Sept 22nd.

Re-structured following key ideas from the feedback.

* Fixed nits 7th October

Fixed nits 7th October

* Incorporated feedback Oct 25th

Incorporated 'invocation triggers warning' and what to do when disabling a no-op.

*  fixed "tide"

Announced for completed

* Incorporated feedback from sig docs
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Nov 26, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Nov 26, 2018

Deploy preview for kubernetes-io-master-staging ready!

Built with commit a48fbad

https://deploy-preview-11330--kubernetes-io-master-staging.netlify.com

@timothysc
Copy link
Member

/assign @Bradamant3 @chuckha @detiber
/cc @kubernetes/sig-cluster-lifecycle-pr-reviews

@k8s-ci-robot k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Nov 26, 2018
@timothysc
Copy link
Member

/assign @fabriziopandini

@Bradamant3 Bradamant3 added this to the 1.13 milestone Nov 26, 2018
Copy link
Member

@timothysc timothysc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks mostly good, I'd prefer @fabriziopandini to cross check.

Add an annotation for the cri-socket to the current node, for example to use docker:

```shell
kubectl annotate node <nodename> kubeadm.alpha.kubernetes.io/cri-socket=/var/run/dockershim.sock
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't need todo this.

Cross checking with @fabriziopandini

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@detiber will be doing a pass for all this stacked control planes section.

@Bradamant3
Copy link
Contributor

Bradamant3 commented Nov 26, 2018

@rdodev can you please rebase on dev-1.13? We don't cherry-pick commits for docs -- we work on a separate release branch before the release. Merges to master are published immediately (CD aka in our world Continuous Improvement ...)

Signed-off-by: Ruben Orduz <rubenoz@gmail.com>
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: bradamant3

If they are not already assigned, you can assign the PR to them by writing /assign @bradamant3 in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rdodev rdodev changed the base branch from master to dev-1.13 November 27, 2018 15:04
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 27, 2018
@rdodev rdodev closed this Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.