Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppArmor documentation #1147

Merged
merged 1 commit into from
Sep 14, 2016
Merged

Conversation

timstclair
Copy link

@timstclair timstclair commented Sep 1, 2016

Adds full documentation for AppArmor.

Original proposal: https://github.com/kubernetes/kubernetes/blob/master/docs/proposals/apparmor.md
Feature issue: kubernetes/enhancements#24

Note: 2 features referenced in this document have not yet been merged:

/cc @thockin @jfrazelle @pwittrock @dchen1107 @matchstick @kubernetes/docs


This change is Reviewable

@devin-donnelly
Copy link
Contributor

Review status: 0 of 4 files reviewed at latest revision, 1 unresolved discussion.


docs/admin/apparmor/index.md, line 7 [r1] (raw file):

---

AppArmor is a Linux kernel enhancement that can reduce the potential attack surface and provide

For clarity, I'd recommend changing to "reduce the potential attack surface of an Application and provide greater defense in depth."


Comments from Reviewable

@devin-donnelly
Copy link
Contributor

Overall excellent. One very minor issue, but Docs LGTM.

@timstclair
Copy link
Author

Thanks! Done.


Review status: 0 of 4 files reviewed at latest revision, 1 unresolved discussion.


docs/admin/apparmor/index.md, line 7 [r1] (raw file):

Previously, devin-donnelly wrote…

For clarity, I'd recommend changing to "reduce the potential attack surface of an Application and provide greater defense in depth."

Done.

Comments from Reviewable

@dchen1107
Copy link
Member

LGTM

@timstclair
Copy link
Author

Squashed commits.

@devin-donnelly
Copy link
Contributor

Looks good, merging to release-1.4 line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants