-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add audit doc #1168
Add audit doc #1168
Conversation
- `audit-log-path` - enables the audit log pointing to a file where the requests are being logged to. | ||
- `audit-log-maxage` - specifies maximum number of days to retain old audit log files based on the timestamp encoded in their filename. | ||
- `audit-log-maxbackup` - specifies maximum number of old audit log files to retain. | ||
- `audit-log-maxsize` - specifies maximum size in megabytes of the audit log file before it gets rotated. Defaults to 100MB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
by "rotated" does it mean the old log gets deleted or is there some naming semantic used inside the path?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
audit-log-maxbackup
specifies how many old files are kept, old files have a timestamp appended at the end. By default there's not limit set on that amount.
799e032
to
77679ff
Compare
Comments addressed, I've additionally added a few words explaining log rotation. ptal |
lgtm |
Rebased. |
Is this change targeting the 1.4 release, or can it be published immediately? |
It's definitely part of 1.4 release, and since it's part of k8s for over a month already can be published immediately as well. |
This looks like a duplicate of Pull Request #1193 . I'm going to close this one. We'll merge the other one. |
Signed-off-by: Charles Pretzer <charles@buoyant.io>
@janetkuo @sttts ptal
This change is