Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add audit doc #1168

Closed
wants to merge 1 commit into from
Closed

Add audit doc #1168

wants to merge 1 commit into from

Conversation

soltysh
Copy link
Contributor

@soltysh soltysh commented Sep 6, 2016

@janetkuo @sttts ptal


This change is Reviewable

- `audit-log-path` - enables the audit log pointing to a file where the requests are being logged to.
- `audit-log-maxage` - specifies maximum number of days to retain old audit log files based on the timestamp encoded in their filename.
- `audit-log-maxbackup` - specifies maximum number of old audit log files to retain.
- `audit-log-maxsize` - specifies maximum size in megabytes of the audit log file before it gets rotated. Defaults to 100MB
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by "rotated" does it mean the old log gets deleted or is there some naming semantic used inside the path?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

audit-log-maxbackup specifies how many old files are kept, old files have a timestamp appended at the end. By default there's not limit set on that amount.

@soltysh soltysh force-pushed the audit_doc branch 2 times, most recently from 799e032 to 77679ff Compare September 7, 2016 13:23
@soltysh
Copy link
Contributor Author

soltysh commented Sep 7, 2016

Comments addressed, I've additionally added a few words explaining log rotation. ptal

@sttts
Copy link
Contributor

sttts commented Sep 7, 2016

lgtm

@soltysh
Copy link
Contributor Author

soltysh commented Sep 7, 2016

Rebased.

@devin-donnelly
Copy link
Contributor

Is this change targeting the 1.4 release, or can it be published immediately?

@soltysh
Copy link
Contributor Author

soltysh commented Sep 7, 2016

It's definitely part of 1.4 release, and since it's part of k8s for over a month already can be published immediately as well.

@soltysh soltysh mentioned this pull request Sep 9, 2016
@devin-donnelly
Copy link
Contributor

This looks like a duplicate of Pull Request #1193 . I'm going to close this one. We'll merge the other one.

@soltysh soltysh deleted the audit_doc branch September 12, 2016 08:11
@soltysh soltysh restored the audit_doc branch September 12, 2016 08:12
@soltysh soltysh deleted the audit_doc branch September 12, 2016 08:12
mikutas pushed a commit to mikutas/k8s-website that referenced this pull request Sep 22, 2022
Signed-off-by: Charles Pretzer <charles@buoyant.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants