-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add document for node conformance test. #1216
Add document for node conformance test. #1216
Conversation
Does this mean the node e2e tests have to be 100% non-flaky? Or will node conformance test retry a few times on failure? |
@davidopp By default, the node conformance test only runs the node e2e test with "[conformance]" label, which should be stable (or else we should fix it or remove the conformance tag) However, add flake retry is a good idea for better user experience. |
Docs LGTM. Needs a Tech LGTM. |
@dchen1107 PTAL. |
LGTM |
|
||
*Node conformance test* is a test framework validating whether a node meets the | ||
minimum requirement of Kubernetes with a set of system verification and | ||
functionality test. A node which passes the test is qualified to join a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/test/tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
|
||
### Run Node Conformance Test for Other Architectures | ||
|
||
We also build node conformance test docker image for other architectures: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/image/images
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK.
test](https://github.com/kubernetes/kubernetes/blob/release-1.4/docs/devel/e2e-node-tests.md). | ||
By default, it runs all conformance test. | ||
|
||
Theoritically, you can run any node e2e test if you configure the container and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/Theoritically/Theoretically
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK.
By default, it runs all conformance test. | ||
|
||
Theoritically, you can run any node e2e test if you configure the container and | ||
mount required volumes properly. But **it is strongly recommanded to only run conformance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/recommanded/recommended
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
test. | ||
* The test will leave dead containers on the node, these containers are created | ||
during the functionality test. | ||
* Node conformance test validates kernel configuration. However, in some os |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be listed in the requirements?
## Prerequisite | ||
|
||
Node conformance test is used to test whether a node is ready to join a | ||
Kubernetes cluster, so the prerequisite is the same with a standard Kubernetes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any documentation on the "prerequisite" of a standard kubernetes npde?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to link somewhere, but I don't think we have it. :(
@pwittrock Docs and Tech Review both passed. |
* wip * fixups Signed-off-by: William Morgan <william@buoyant.io> Co-authored-by: Tarun Pothulapati <tarunpothulapati@outlook.com>
This PR added a document for the node conformance test to
Creating a Cluster/Running Kubernetes on Custom Solutions/Validate Node Setup
@dchen1107
/cc @kubernetes/sig-node
This change"s