-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust for Minikube running RBAC by default #12851
Adjust for Minikube running RBAC by default #12851
Conversation
Deploy preview for kubernetes-io-master-staging ready! Built with commit b063416 https://deploy-preview-12851--kubernetes-io-master-staging.netlify.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @sftim .
I suggest you update the content with details as mentioned in https://github.com/kubernetes-incubator/service-catalog/blob/master/docs/install.md#rbac
'now' is a very ambiguous word.
3b66077
to
3687085
Compare
Good suggestion @Rajakavitha1, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix @sftim . May be "Minikube now has RBAC authorization enabled by default." is redundant.
3687085
to
b063416
Compare
I'm going to put this down to an execution ordering issue: I redid this PR before I had any coffee. |
Checked the updates on: https://deploy-preview-12851--kubernetes-io-master-staging.netlify.com/docs/tasks/service-catalog/install-service-catalog-using-helm/ /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Rajakavitha1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fix for #12751
Note that Minikube has RBAC enabled by default. Provide instructions just in case someone is using an older version.