Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust for Minikube running RBAC by default #12851

Merged
merged 1 commit into from
Feb 27, 2019
Merged

Adjust for Minikube running RBAC by default #12851

merged 1 commit into from
Feb 27, 2019

Conversation

sftim
Copy link
Contributor

@sftim sftim commented Feb 26, 2019

Fix for #12751

Note that Minikube has RBAC enabled by default. Provide instructions just in case someone is using an older version.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 26, 2019
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language labels Feb 26, 2019
@netlify
Copy link

netlify bot commented Feb 26, 2019 •
edited

Deploy preview for kubernetes-io-master-staging ready!

Built with commit b063416

https://deploy-preview-12851--kubernetes-io-master-staging.netlify.com

Rajakavitha1
Rajakavitha1 suggested changes Feb 27, 2019
View reviewed changes
Copy link
Contributor

@Rajakavitha1 Rajakavitha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @sftim .
I suggest you update the content with details as mentioned in https://github.com/kubernetes-incubator/service-catalog/blob/master/docs/install.md#rbac
'now' is a very ambiguous word.

@sftim sftim force-pushed the install_service_catalog_using_helm_minikube_rbac branch from 3b66077 to 3687085 Compare February 27, 2019 13:36
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 27, 2019
@sftim
Copy link
Contributor Author

sftim commented Feb 27, 2019

Good suggestion @Rajakavitha1, thanks!

Rajakavitha1
Rajakavitha1 suggested changes Feb 27, 2019
View reviewed changes
Copy link
Contributor

@Rajakavitha1 Rajakavitha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @sftim . May be "Minikube now has RBAC authorization enabled by default." is redundant.

@sftim sftim force-pushed the install_service_catalog_using_helm_minikube_rbac branch from 3687085 to b063416 Compare February 27, 2019 14:13
@sftim
Copy link
Contributor Author

sftim commented Feb 27, 2019

I'm going to put this down to an execution ordering issue: I redid this PR before I had any coffee.
Will fix & force-push.

@Rajakavitha1
Copy link
Contributor

Checked the updates on: https://deploy-preview-12851--kubernetes-io-master-staging.netlify.com/docs/tasks/service-catalog/install-service-catalog-using-helm/

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Rajakavitha1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2019
@k8s-ci-robot k8s-ci-robot merged commit 79b1825 into kubernetes:master Feb 27, 2019
kwiesmueller pushed a commit to kwiesmueller/website that referenced this pull request Feb 28, 2019
@sftim
Adjust for Minikube running RBAC by default (kubernetes#12851)
000a8ee
krmayankk pushed a commit to krmayankk/kubernetes.github.io that referenced this pull request Mar 11, 2019
@sftim
Adjust for Minikube running RBAC by default (kubernetes#12851)
5eb88ba
yagonobre pushed a commit to yagonobre/website that referenced this pull request Mar 14, 2019
@sftim @yagonobre
Adjust for Minikube running RBAC by default (kubernetes#12851)
870ea80
@sftim sftim deleted the install_service_catalog_using_helm_minikube_rbac branch June 9, 2021 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rajakavitha1 Rajakavitha1 Rajakavitha1 requested changes

@chenopis chenopis Awaiting requested review from chenopis

@xiangpengzhao xiangpengzhao Awaiting requested review from xiangpengzhao

Assignees

@Rajakavitha1 Rajakavitha1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sftim @Rajakavitha1 @k8s-ci-robot