Add docs for perma-failed deployments #1337
Conversation
|
Docs for kubernetes/kubernetes#19343 |
| it. Once a Deployment times out, a related timeout Condition will be added in the status of the Deployment. Note that | ||
| if the error is transient eg. you have specified a low timeout or you don't have enough quota and all you need is to | ||
| scale down your Deployment or scale down other Pods you may be running then once the deployment controller notices | ||
| that your Deployment is complete, it will transition the failure condition into a succeeded one. |
There was a problem hiding this comment.
I think you need a sentence here about what being "failed" means (i.e. if the platform does anything beyond adding the condition, say that, otherwise say that Kube does nothing else). You should also include the example of how the JSON would look, and how kubectl get would look so someone could understand just by looking what this condition looks like.
| @@ -451,7 +451,79 @@ nginx-deployment-2035384211 0 0 1h | |||
| nginx-deployment-3066724191 0 0 1h | |||
| ``` | |||
|
|
|||
| Note: A paused Deployment cannot be scaled at this moment, and we will add this feature in 1.3 release, see [issue #20853](https://github.com/kubernetes/kubernetes/issues/20853). You cannot rollback a paused Deployment either, and you should resume a Deployment first before doing a rollback. | |||
| Note: You cannot rollback a paused Deployment. You should resume it first before doing a rollback. | |||
There was a problem hiding this comment.
Could you create a separate PR for this? This change can go live now.
|
Note that since perma-failed deployment isn't merged/released yet, this should either target 1.5 release branch (not yet created) or be added to 1.5 milestone (not yet created) and hold merging until 1.5. |
janetkuo
added
component/deployment
do-not-merge
Automatic merge from submit-queue Add perma-failed deployments API @kubernetes/deployment @smarterclayton API for #14519 Docs at kubernetes/website#1337
|
Note: this depends on kubernetes/kubernetes#19343 (merged) and kubernetes/kubernetes#35691 |
…failed Automatic merge from submit-queue Controller changes for perma failed deployments This PR adds support for reporting failed deployments based on a timeout parameter defined in the spec. If there is no progress for the amount of time defined as progressDeadlineSeconds then the deployment will be marked as failed by a Progressing condition with a ProgressDeadlineExceeded reason. Follow-up to #19343 Docs at kubernetes/website#1337 Fixes #14519 @kubernetes/deployment @smarterclayton
Also kubernetes/kubernetes#36171 for the cli changes. All three of them are now merged. |
|
@Kargakis not sure if you saw @jaredbhatti's mail regarding docs targeting 1.5 features. Would you open another PR for this change, targeting 1.5 branch (instead of master), and assign or cc me there? |
|
Ref feature issue kubernetes/enhancements#122 |
janetkuo
removed
the
do-not-merge
|
Opened #1699 |
Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
@kubernetes/deployment @erictune @smarterclayton
This change is