Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update required quobyte secret structure #14876

Merged
merged 1 commit into from
Aug 21, 2019

Conversation

sfudeus
Copy link
Contributor

@sfudeus sfudeus commented Jun 13, 2019

While setting up a quobyte integration I noticed that the info about the secret's structure is incorrect. The official quobyte documentation can be found here: https://github.com/quobyte/kubernetes/blob/master/using_quobyte_volumes.md

@k8s-ci-robot
Copy link
Contributor

Welcome @sfudeus!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 13, 2019
@k8s-ci-robot k8s-ci-robot requested review from jsafrane and msau42 June 13, 2019 14:51
@netlify
Copy link

netlify bot commented Jun 13, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 8d01cb7

https://deploy-preview-14876--kubernetes-io-master-staging.netlify.com

@zhangqx2010
Copy link
Contributor

@sfudeus Thanks for your PR. Please sign CLA first.

@sfudeus
Copy link
Contributor Author

sfudeus commented Jun 15, 2019

@zhangqx2010 Sure, working on it. But the corporate CLA will most likely take some weeks.

@zhangqx2010
Copy link
Contributor

@sfudeus Just few seconds will. If you have signed, do /check-cla

@zhangqx2010
Copy link
Contributor

zhangqx2010 commented Jun 16, 2019

And I remember there is a quick script will help you to get it done.
https://github.com/zparnold/k8s-docs-pr-botherer

@tengqm
Copy link
Contributor

tengqm commented Jul 24, 2019

@sfudeus I'm closing this PR because the CLA status check has not been resolved for over a month. Please

  • feel free to reopen this if you are still working on it, and
  • try follow instructions here to debug your CLA status if you have already signed it.

@tengqm tengqm closed this Jul 24, 2019
@sfudeus
Copy link
Contributor Author

sfudeus commented Jul 27, 2019

/reopen
Still working on the CLA, currently in process to be signed by CIO.

@sfudeus
Copy link
Contributor Author

sfudeus commented Aug 16, 2019

/check-cla

@sfudeus
Copy link
Contributor Author

sfudeus commented Aug 16, 2019

@tengqm Seems I cannot reopen, CLA is signed now. Could you help here?

@sfudeus
Copy link
Contributor Author

sfudeus commented Aug 19, 2019

/reopen

@k8s-ci-robot k8s-ci-robot reopened this Aug 19, 2019
@k8s-ci-robot
Copy link
Contributor

@sfudeus: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sfudeus

This comment has been minimized.

2 similar comments
@sfudeus

This comment has been minimized.

@sfudeus
Copy link
Contributor Author

sfudeus commented Aug 20, 2019

/check-cla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 20, 2019
@msau42
Copy link
Member

msau42 commented Aug 20, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 20, 2019
@kbarnard10
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kbarnard10

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2019
@k8s-ci-robot k8s-ci-robot merged commit d61d3be into kubernetes:master Aug 21, 2019
wahyuoi pushed a commit to wahyuoi/website that referenced this pull request Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants