Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate CCM page in French #14960

Merged
merged 2 commits into from
Aug 20, 2019
Merged

Translate CCM page in French #14960

merged 2 commits into from
Aug 20, 2019

Conversation

remyleone
Copy link
Contributor

No description provided.

@remyleone remyleone self-assigned this Jun 18, 2019
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. language/fr Issues or PRs related to French language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jun 18, 2019
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 18, 2019
@netlify
Copy link

netlify bot commented Jun 18, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 2882845

https://deploy-preview-14960--kubernetes-io-master-staging.netlify.com

@remyleone remyleone changed the title WIP: Translate CCM page in French Translate CCM page in French Jul 5, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 5, 2019
@remyleone
Copy link
Contributor Author

@anthonydahanne fixed

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jul 30, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jul 30, 2019
@rekcah78
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 30, 2019
@xiangpengzhao
Copy link
Contributor

/assign @oussemos

@remyleone @sftim
Update content/fr/docs/tasks/administer-cluster/running-cloud-control…
2882845 
…ler.md

Co-Authored-By: Tim Bannister <tim@scalefactory.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 20, 2019
@remyleone
Copy link
Contributor Author

@rekcah78 Est ce que tu peux mettre un nouveau LGTM et un approve ?

@rekcah78
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 20, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rekcah78

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 20, 2019
@k8s-ci-robot k8s-ci-robot merged commit b9b9516 into kubernetes:master Aug 20, 2019
wahyuoi pushed a commit to wahyuoi/website that referenced this pull request Sep 9, 2019
@remyleone @sftim @wahyuoi
Translate CCM page in French (kubernetes#14960)
c002e83 
* Translate CCM page in French

* Update content/fr/docs/tasks/administer-cluster/running-cloud-controller.md

Co-Authored-By: Tim Bannister <tim@scalefactory.com>
@anthonydahanne anthonydahanne mentioned this pull request Oct 17, 2019
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@rekcah78 rekcah78 rekcah78 left review comments

@anthonydahanne anthonydahanne anthonydahanne requested changes

@abuisine abuisine Awaiting requested review from abuisine

Assignees

@remyleone remyleone

@oussemos oussemos

@rekcah78 rekcah78

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/fr Issues or PRs related to French language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@remyleone @rekcah78 @xiangpengzhao @k8s-ci-robot @anthonydahanne @sftim @oussemos