-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update service.md #15738
Update service.md #15738
Conversation
adjust grammer
Welcome @ponypaver! |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Deploy preview for kubernetes-io-master-staging ready! Built with commit b310fc3 https://deploy-preview-15738--kubernetes-io-master-staging.netlify.com |
I signed it |
@@ -356,7 +356,7 @@ that are configured for a specific IP address and difficult to re-configure. | |||
The IP address that you choose must be a valid IPv4 or IPv6 address from within the | |||
`service-cluster-ip-range` CIDR range that is configured for the API server. | |||
If you try to create a Service with an invalid clusterIP address value, the API | |||
server will returns a 422 HTTP status code to indicate that there's a problem. | |||
server will return a 422 HTTP status code to indicate that there's a problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good spot!
With the style guide in mind, can I suggest:
server will return a 422 HTTP status code to indicate that there's a problem. | |
server returns a 422 HTTP status code to indicate that there's a problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's essentially a nit, and this is also OK to merge as is, so:
/lgtm
lgtm |
/assign @ryanmcginnis |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ryanmcginnis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
adjust grammer
adjust grammer
adjust grammar