Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api deprecation blogpost: Include minimum kube version for ingress from networking apigroup #15740

Merged
merged 1 commit into from
Aug 12, 2019

Conversation

alvaroaleman
Copy link
Member

Ingress lacks the info what the minimum required Kube version is, its included for all other resources mentioned.

/assign @vllry

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/blog Issues or PRs related to the Kubernetes Blog subproject language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 8, 2019
@netlify
Copy link

netlify bot commented Aug 8, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit df1d1c8

https://deploy-preview-15740--kubernetes-io-master-staging.netlify.com

@@ -34,8 +34,8 @@ from **extensions/v1beta1**, **apps/v1beta1**, or **apps/v1beta2** in **v1.16**.
* Migrate to the apps/v1 API, available since v1.9. Existing persisted data
can be retrieved/updated via the apps/v1 API.
* Ingress: will no longer be served from **extensions/v1beta1** in **v1.18**.
* Migrate to the networking.k8s.io/v1beta1 API. Existing persisted data can be
retrieved/updated via the networking.k8s.io/v1beta1 API.
* Migrate to the networking.k8s.io/v1beta1 API, serving Ingress since v1.14.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: I recommend saying "available since v1.14"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I deliberately put it like that because the networking.k8s.io apigroup is available since 1.8 and Ingress itself since 1.1. The only thing changed with 1.14 is that you can now get the Ingress kind via the networking.k8s.io apigroup.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha! Thank you, @alvaroaleman 👍🏼

@vllry
Copy link
Contributor

vllry commented Aug 8, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 8, 2019
@onlydole
Copy link
Member

onlydole commented Aug 8, 2019

Thank you, @alvaroaleman! Looks good to me from a technical perspective.

/lgtm
/assign @kbarnard10

@kbarnard10
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kbarnard10

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2019
@k8s-ci-robot k8s-ci-robot merged commit 3bea36b into kubernetes:master Aug 12, 2019
Klaven pushed a commit to Klaven/website that referenced this pull request Aug 15, 2019
wahyuoi pushed a commit to wahyuoi/website that referenced this pull request Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants