-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Api deprecation blogpost: Include minimum kube version for ingress from networking apigroup #15740
Conversation
…om networking apigroup
Deploy preview for kubernetes-io-master-staging ready! Built with commit df1d1c8 https://deploy-preview-15740--kubernetes-io-master-staging.netlify.com |
@@ -34,8 +34,8 @@ from **extensions/v1beta1**, **apps/v1beta1**, or **apps/v1beta2** in **v1.16**. | |||
* Migrate to the apps/v1 API, available since v1.9. Existing persisted data | |||
can be retrieved/updated via the apps/v1 API. | |||
* Ingress: will no longer be served from **extensions/v1beta1** in **v1.18**. | |||
* Migrate to the networking.k8s.io/v1beta1 API. Existing persisted data can be | |||
retrieved/updated via the networking.k8s.io/v1beta1 API. | |||
* Migrate to the networking.k8s.io/v1beta1 API, serving Ingress since v1.14. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: I recommend saying "available since v1.14"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I deliberately put it like that because the networking.k8s.io
apigroup is available since 1.8 and Ingress itself since 1.1. The only thing changed with 1.14 is that you can now get the Ingress kind via the networking.k8s.io
apigroup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha! Thank you, @alvaroaleman 👍🏼
/lgtm |
Thank you, @alvaroaleman! Looks good to me from a technical perspective. /lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kbarnard10 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…om networking apigroup (kubernetes#15740)
…om networking apigroup (kubernetes#15740)
Ingress lacks the info what the minimum required Kube version is, its included for all other resources mentioned.
/assign @vllry