Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

comment version #15808

Closed
wants to merge 1 commit into from
Closed

comment version #15808

wants to merge 1 commit into from

Conversation

daixiang0
Copy link
Contributor

Refer to kubernetes/kubernetes#42873, only support over 1.11.0

Signed-off-by: Xiang Dai 764524258@qq.com

@daixiang0
comment version
38c788a 
Signed-off-by: Xiang Dai <764524258@qq.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 12, 2019
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Aug 12, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign rajakavitha1
You can assign the PR to them by writing /assign @rajakavitha1 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify
Copy link

netlify bot commented Aug 12, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 38c788a

https://deploy-preview-15808--kubernetes-io-master-staging.netlify.com

@daixiang0
Copy link
Contributor Author

/assign @Rajakavitha1

tengqm
tengqm reviewed Aug 12, 2019
View reviewed changes
content/en/docs/concepts/overview/working-with-objects/namespaces.md
@@ -101,7 +101,7 @@ in some namespaces. However namespace resources are not themselves in a namespa
And low-level resources, such as [nodes](/docs/admin/node) and
persistentVolumes, are not in any namespace.

To see which Kubernetes resources are and aren't in a namespace:
To see which Kubernetes resources are and aren't in a namespace, only support over v1.11.0:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.11.0 is a "long" history. We are about to deprecate docs for 1.11.0. Does it still make sense to mention an old version in the new doc?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it, but in production env, i think 1.10.0 still exist, comment version is exact.

@daixiang0 daixiang0 closed this Aug 31, 2019
@daixiang0 daixiang0 deleted the comment-version branch August 31, 2019 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tengqm tengqm tengqm left review comments

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@thockin thockin Awaiting requested review from thockin

Assignees

@Rajakavitha1 Rajakavitha1

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@daixiang0 @k8s-ci-robot @tengqm @Rajakavitha1