-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSON to YAML for external LoadBalancer #15891
Conversation
Welcome @programmer04! |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Deploy preview for kubernetes-io-master-staging ready! Built with commit 8793043 https://deploy-preview-15891--kubernetes-io-master-staging.netlify.com |
/assign @Bradamant3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvements @programmer04
/lgtm
I've spotted and listed some improvements you could make beyond the ones you've listed here, if you'd like to. To be clear, though, this seems fine to merge as-is.
Mostly these are inline feedback.
The one other tweak I saw is around:
This provides an externally-accessible IP address that sends traffic to the correct port on your cluster nodes provided your cluster runs in a supported environment and is configured with the correct cloud load balancer provider package.
If you have the appetite for a few more changes, you could move that text to be part of the prerequisites section. I think that's a better place for it.
content/en/docs/tasks/access-application-cluster/create-external-load-balancer.md
Outdated
Show resolved
Hide resolved
content/en/docs/tasks/access-application-cluster/create-external-load-balancer.md
Outdated
Show resolved
Hide resolved
content/en/docs/tasks/access-application-cluster/create-external-load-balancer.md
Outdated
Show resolved
Hide resolved
Howdy @sftim, thanks for the review, I applied all suggestion. Please check |
These changes are clearly improving the existing content. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Yaml instead of json for LoadBalancer * Fixes from style guide * Improve style * Remove obsolete fragments
Make this page consistent: