Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove inactive approver #15954

Merged
merged 1 commit into from
Aug 19, 2019
Merged

Remove inactive approver #15954

merged 1 commit into from
Aug 19, 2019

Conversation

zacharysarah
Copy link
Contributor

This PR removes @zhangxiaoyu-zidif from English approvers.

With only one PR in the past year and with no response to PR wrangling responsibilities, it looks like @zhangxiaoyu-zidif may have moved on from K8s docs.

Tim, we wish you well! Thanks for all of your contributions, and best wishes for all your future endeavors. 🙇

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 19, 2019
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Aug 19, 2019
@netlify
Copy link

netlify bot commented Aug 19, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 1d34c5b

https://deploy-preview-15954--kubernetes-io-master-staging.netlify.com

@jimangel
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 19, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jimangel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2019
@k8s-ci-robot k8s-ci-robot merged commit d10ac36 into kubernetes:master Aug 19, 2019
@zacharysarah zacharysarah deleted the prune-approvers branch August 19, 2019 23:24
@zhangxiaoyu-zidif
Copy link
Contributor

@zacharysarah
Thanks, Zach. I am busy in developing Kubernetes code this year, so I paid little effort on Docs. When I am free from current work, I will be back to Docs maintaining. Then I will continue to help review Docs and send some PR for bugfix.
Thanks all, Sig-Docs :)

wahyuoi pushed a commit to wahyuoi/website that referenced this pull request Sep 9, 2019
@zacharysarah @wahyuoi
Remove inactive approver (kubernetes#15954)
98fe276
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rajakavitha1 Rajakavitha1 Awaiting requested review from Rajakavitha1

@zhangxiaoyu-zidif zhangxiaoyu-zidif Awaiting requested review from zhangxiaoyu-zidif

Assignees

@jimangel jimangel

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zacharysarah @jimangel @k8s-ci-robot @zhangxiaoyu-zidif