-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update window storage driver list with EBS #16300
Conversation
/milestone 1.16 |
@leakingtapan: You must be a member of the kubernetes/website-milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Website milestone maintainers and have them propose you as an additional delegate for this responsibility. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Deploy preview for kubernetes-io-master-staging ready! Built with commit 46a8956 https://deploy-preview-16300--kubernetes-io-master-staging.netlify.com |
/approve |
are we supposed to check into master, or dev-1.16 instead? |
Since 1.16 is not released yet, so I point it to master. Let me know which branch should I use @michmike |
@leakingtapan If this is going in with 1.16, this needs to be open against dev-1.16 and may need a rebase. Once this is done, I am happy to merge. |
i was going to say the exact same thing as @simplytunde . this should be in dev1.16 |
46a8956
to
574e4c8
Compare
Deploy preview for kubernetes-io-vnext-staging processing. Building with commit 0f8047a https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5d7a83bf6489f400082c9f68 |
0b5cce1
to
0f8047a
Compare
@michmike rebased against dev-1.16 PTAL |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michmike, simplytunde The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Update window storage driver list with EBS as EBS windows support was fixed by kubernetes/kubernetes#79552
/cc @wongma7 @PatrickLang @michmike