Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issue 17274 #17277

Merged
merged 1 commit into from
Oct 29, 2019
Merged

fix issue 17274 #17277

merged 1 commit into from
Oct 29, 2019

Conversation

lojies
Copy link
Contributor

@lojies lojies commented Oct 29, 2019

fix #17274

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 29, 2019
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Oct 29, 2019
@lojies lojies changed the title fix #17274 fix issue 17274 Oct 29, 2019
@lojies lojies force-pushed the staticpod_20191029 branch from 31996d4 to 75fd223 Compare October 29, 2019 10:25
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Oct 29, 2019
@netlify
Copy link

netlify bot commented Oct 29, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 31996d4

https://deploy-preview-17277--kubernetes-io-master-staging.netlify.com

@netlify
Copy link

netlify bot commented Oct 29, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 75fd223

https://deploy-preview-17277--kubernetes-io-master-staging.netlify.com

@bradtopol
Copy link
Contributor

/assign

@bradtopol
Copy link
Contributor

/assign

@bradtopol
Copy link
Contributor

Great job! Confirmed that the fix renders properly
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 29, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bradtopol

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2019
@k8s-ci-robot k8s-ci-robot merged commit 8db2d7b into kubernetes:master Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsafrane jsafrane Awaiting requested review from jsafrane

@Rajakavitha1 Rajakavitha1 Awaiting requested review from Rajakavitha1

Assignees

@bradtopol bradtopol

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with k8s.io/docs/tasks/configure-pod-container/static-pod/
3 participants
@lojies @bradtopol @k8s-ci-robot