-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move init containers to stable in v1.6 #1939
Move init containers to stable in v1.6 #1939
Conversation
@hodovska If this PR isn't relevant until the 1.6 release, it's going to sit here for a while without being merged. |
@@ -162,7 +157,7 @@ reasons: | |||
## Support and compatibilty | |||
|
|||
A cluster with Kubelet and Apiserver version 1.4.0 or greater supports init |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe say:
A cluster with Apiserver version 1.6.0 or greater supports init containers using the
spec.initContainers
field. Previous versions support init containers using the alpha or beta annotations. Thespec.initContainers
field is also mirrored into alpha and beta annotations so that Kubelets version 1.3.0 or greater can execute init containers, and so that a version 1.6 apiserver can safely be rolled back to version 1.5.x without losing init container function for existing created pods.
Thanks @hodovska for updating this. Looks pretty good. One suggestion |
2e4f14a
to
80e24fd
Compare
@hodovska FYI, the kubernetes:release-1.6 branch is now available. Please change the base branch to that. Thx |
80e24fd
to
13ec474
Compare
@erictune I rebased PR and made relevant changes, could you please review it again, since the structure changed in 1.6? |
@hodovska I made some minor changes to make the docs more consistent w/ how we capitalize Container and Init Container when they are referenced as concepts instead of specific instances. |
@erictune Ping me when you give your final LGTM. I will merge this PR then. Thx |
Delete the parameter "--google-json-key string"
Ubuntu default install not include apt-transport-https. so if you want to download package from https repo, you need install apt-transport-https package first
modify
I think it's redundant that the second to ,in order to do sth and do sth!thanks!
fix command kubectl get svc,pod output
fix the link of logging-elasticsearch-kibana.md
update init-containers.md
update out-of-resource.md
[UX] "View $PAGE on GitHub" without forking the repo
Added info about controller manager setup and current implementation when using PSP with RBAC support.
fix a typo in /docs/user-guide/configmap/index.md
amend monitor-node-health.md
Fix monitor-node-health.md
Update manage-compute-resources-container.md
fix the command output
…ixing docs/admin: document OpenID Connect plugin's claim prefixing
PSP: Added example and docu for hostPort ranges
* fix typeo * Update kargo.md
evaluation --> evaluated
* Apply typo fixes from kubernetes#2791 * remove style typos
Signed-off-by: yupengzte <yu.peng36@zte.com.cn>
…hub.io into init-cont-doc-1.6 * 'master' of https://github.com/kubernetes/kubernetes.github.io: (350 commits) Fix typo (kubernetes#2842) Fix typo Fix the typos Apply typo fixes from kubernetes#2791 (kubernetes#2949) Fix typo in kubectl_completion.md fix typeo (kubernetes#2856) Use kubectl config current-context to simplify the instructions updated PSP documentation with RBAC (kubernetes#2552) Create hyperlink Add files via upload Fix typo Remove from TOC/Search: pods/init-containers ... (kubernetes#2694) fix the link of ogging-elasticsearch-kibana.md Add files via upload fix to taint the master node Move Guide topics: Container Lifestyle Hooks, Images, Volumes View $PAGE on Github without forking the repo fix a typo in /docs/user-guide/configmap/index.md Fix monitor-node-health.md amend monitor-node-health.md ... # Conflicts: # docs/tasks/configure-pod-container/configure-pod-initialization.md
@hodovska I merged in |
* added content/es/serverless.md Signed-off-by: marianogg9 <gonzalez.mariano.gabriel@gmail.com>
Since init containers concept was proved in beta version in 1.4 and 1.5 it can be moved to stable in 1.6.
upstream PR: kubernetes/kubernetes#38382
trello: https://trello.com/c/Yr7TRKHr/578-5-node-promote-init-containers-to-ga
This change is![Reviewable](https://camo.githubusercontent.com/2d899f4291d07d3cd2fa4aaae1e3b243f164c23fce87d30a589ace0d496a444c/68747470733a2f2f72657669657761626c652e6b756265726e657465732e696f2f7265766965775f627574746f6e2e737667)