Kick off فارسی (Persian) localization #22565

sattarfgh · 2020-07-17T20:06:19Z

This is the Persian Language documentation PR.

Thank you.

k8s-ci-robot · 2020-07-17T20:06:24Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

netlify · 2020-07-17T20:16:44Z

Deploy preview for kubernetes-io-master-staging ready!

Built with commit db8abc8

https://deploy-preview-22565--kubernetes-io-master-staging.netlify.app

rlenferink

Thanks for creating this. Can you follow the steps in https://kubernetes.io/docs/contribute/localization/ for e.g. creating the teams at org level ? Thanks

OWNERS_ALIASES

content/fa/OWNERS

sftim · 2020-07-19T18:06:00Z

/retitle Add فارسی (Persian) localization

(hope that's OK)

sftim · 2020-07-19T18:07:16Z

I think this is a work-in-progress (it needs more work before it is ready to review); is that right @sattarfeizollahibarough?

sattarfgh · 2020-07-20T07:26:15Z

@sftim Yes, That's right and thank you for your contribution. We are working on the translation right now, however, It's mentioned that on the first step we should PR for minimum requirements.

sftim · 2020-07-20T08:46:55Z

See https://kubernetes.io/docs/contribute/localization/#translating-content for a list of the translations you must complete for a new localization before it can be merged.

This is still a substantial task. If you'd like to, we can help you work on a (new) branch and then send in a pull request to merge all the changes from that branch into master. Would that be useful?

sftim · 2020-07-20T08:47:40Z

/retitle [WIP] Add فارسی (Persian) localization

sattarfgh · 2020-07-20T09:31:04Z

@sftim Yes you are right, working on a new branch is much more better idea. I would be appreciated if you could do that. Thank you in advance.

zacharysarah

@sattarfeizollahibarough Great start.

OWNERS_ALIASES

content/fa/OWNERS

kasramp · 2020-07-25T07:39:06Z

Hi @zacharysarah and @sftim. I've been discussing about K8s Persian translations with @sattarfeizollahibarough offline for sometimes.
To proceed with it further (and become a trusted org member), shall I open an issue similar to kubernetes/org#2058 and tag you guys as there sponsors?

Thanks

sattarfgh · 2020-07-25T09:47:44Z

Hi @zacharysarah and @sftim. I've been discussing about K8s Persian translations with @sattarfeizollahibarough offline for sometimes.
To proceed with it further (and become a trusted org member), shall I open an issue similar to kubernetes/org#2058 and tag you guys as there sponsors?

Thanks

Hi @kasramp, Yes you should submit the request. I can be the first sponsor. And We appreciate if @sftim can be the second sponsor.

sftim · 2020-07-25T12:46:59Z

@sattarfeizollahibarough you can now change the base branch for this PR to dev-1.18-fa.1 and we can look at getting this merged. Then it will make sense to open a new long lived PR for merging dev-1.18-fa.1 into master, because you can then use the long-lived PR to preview the Persian localization.

I suggest that you initially omit the owner files to get started, those can arrive in a later PR.

sftim · 2020-09-16T13:51:09Z

I'd be happy to merge this. I can't review the Farsi / Persian, but I'm keen to see this move forward.
/approve

k8s-ci-robot · 2020-09-16T13:51:24Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [sftim]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

config.toml

sftim · 2020-09-16T13:52:17Z

What I might suggest @sattarfeizollahibarough is that I push a manually rebased version of this PR, and then merge that.
Before I do I'll collect the appropriate approvals etc.

kbhawkey · 2020-09-16T13:53:28Z

content/fa/_common-resources/images/blocks.svg

@@ -0,0 +1 @@
+<svg id="Layer_1" data-name="Layer 1" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 214 210"><defs><style>.cls-1{fill:#316ce6;}.cls-2{fill:#09c1d1;}.cls-3{fill:#c9e9ec;}</style></defs><title>kubernetes_icons</title><rect class="cls-1" x="10.24" y="8.775" width="33.6" height="33.6" rx="4.158"/><rect class="cls-1" x="10.24" y="46.975" width="33.6" height="33.6" rx="4.158"/><rect class="cls-1" x="170.2" y="8.775" width="33.6" height="33.6" rx="4.158"/><rect class="cls-1" x="90.18" y="86.925" width="33.6" height="33.6" rx="4.158"/><rect class="cls-1" x="50.23" y="126.825" width="33.6" height="33.6" rx="4.158"/><rect class="cls-1" x="10.24" y="166.085" width="33.6" height="33.6" rx="4.158"/><rect class="cls-1" x="90.22" y="166.085" width="33.6" height="33.6" rx="4.158"/><rect class="cls-2" x="89.99" y="8.775" width="33.6" height="33.6" rx="4.158"/><rect class="cls-3" x="89.99" y="48.1" width="33.6" height="33.6" rx="4.158"/><rect class="cls-3" x="49.914" y="8.775" width="33.6" height="33.6" rx="4.158"/><rect class="cls-3" x="10.24" y="86.925" width="33.6" height="33.6" rx="4.158"/><rect class="cls-3" x="50.23" y="166.085" width="33.6" height="33.6" rx="4.158"/><rect class="cls-3" x="130.21" y="126.825" width="33.6" height="33.6" rx="4.158"/><rect class="cls-3" x="170.2" y="166.085" width="33.6" height="33.6" rx="4.158"/><rect class="cls-2" x="49.914" y="48.1" width="33.6" height="33.6" rx="4.158"/><rect class="cls-2" x="50.21" y="86.925" width="33.6" height="33.6" rx="4.158"/><rect class="cls-2" x="130.15" y="86.925" width="33.6" height="33.6" rx="4.158"/><rect class="cls-2" x="170.2" y="126.825" width="33.6" height="33.6" rx="4.158"/><rect class="cls-2" x="10.24" y="126.825" width="33.6" height="33.6" rx="4.158"/><rect class="cls-2" x="130.21" y="166.085" width="33.6" height="33.6" rx="4.158"/><rect class="cls-2" x="90.22" y="126.825" width="33.6" height="33.6" rx="4.158"/></svg>


I have not looked at the branch or preview. Do you need to commit the SVG files?

sftim · 2020-09-16T13:54:22Z

⚠️ this PR changes the Japanese localization - is that intended?

kbhawkey · 2020-09-16T13:57:24Z

content/fa/docs/setup/_index.md

+---
+no_issue: true
+title: setup
+main_menu: true


nit: Does this front matter match the front matter in content/en/docs/setup/_index.md?

kbhawkey · 2020-09-16T14:01:40Z

⚠️ this PR changes the Japanese localization - is that intended?

@sattarfeizollahibarough , ☝️ , Is there a reason to delete the three ja files? If not, are you able to remove these changes from this PR?

kbhawkey · 2020-09-16T14:04:19Z

@sattarfeizollahibarough Thanks.

@sftim @kbhawkey 👋 Any thoughts on why Netlify seems to have abandoned the build for this PR?

Hi. I just saw this comment. I'd like to see a build of this branch before merging. What is missing?

kbhawkey · 2020-09-16T14:08:38Z

Is the membership pending:
kubernetes/org#2051

sftim · 2020-09-16T14:16:16Z

Netlify doesn't build previews for that target branch.

kbhawkey · 2020-09-16T14:16:48Z

@sattarfeizollahibarough

Is it possible, they name you and someone else as a sponsor? if yes who?

Sorry for the late response. Yes, I can sponsor.

kbhawkey · 2020-09-16T14:17:12Z

Netlify doesn't build previews for that target branch.

Yes, but should it?

sattarfgh · 2020-09-16T14:21:09Z

@sattarfeizollahibarough

Is it possible, they name you and someone else as a sponsor? if yes who?

Sorry for the late response. Yes, I can sponsor.

@kbhawkey Thank you for you kindness, @sftim and @zacharysarah sponsored me and I have already joint to the Kubernetes members. Any other membership is required?

sattarfgh · 2020-09-16T14:22:02Z

warning this PR changes the Japanese localization - is that intended?

Nope! I'm sorry, I think it's my mistake. I will fix that.

sattarfgh · 2020-09-16T14:43:33Z

warning this PR changes the Japanese localization - is that intended?

It is kind of weird. 😕 I couldn't find the given files ( docker.md, mirror-pod.md , and static-pod.md ) in none of the branches 🤔

kbhawkey · 2020-09-16T14:50:26Z

config.toml

 languagedirection = "ltr"

 [languages.ru]
 title = "Kubernetes"
 description = "Первоклассная оркестрация контейнеров"
 languageName = "Русский"
-weight = 12
+weight = 13


Currently in master repository of Kubernetes the Vietnamese and Russian languages have the same weight 11!!!

Sorry for the confusion. I do see that there is duplication and did not realize the ordering of the
weights.

kbhawkey · 2020-09-16T14:58:05Z

warning this PR changes the Japanese localization - is that intended?

It is kind of weird. 😕 I couldn't find the given files ( docker.md, mirror-pod.md , and static-pod.md ) in none of the branches 🤔

Is this what you are looking for:
https://github.com/kubernetes/website/blob/master/content/ja/docs/reference/glossary/docker.md

sattarfgh · 2020-09-16T15:10:14Z

warning this PR changes the Japanese localization - is that intended?

It is kind of weird. 😕 I couldn't find the given files ( docker.md, mirror-pod.md , and static-pod.md ) in none of the branches 🤔

Is this what you are looking for:
https://github.com/kubernetes/website/blob/master/content/ja/docs/reference/glossary/docker.md

Yep, But I supposed those files should be in dev-1.18 or dev-118-ja branches, which obviously they are not!
Should I copy those from the master branch to my branch?

sftim · 2020-09-16T15:26:21Z

Should I copy those from the master branch to my branch?

This is where I think a manual rebase + squash could be helpful. I can help with that if needed.

sattarfgh · 2020-09-16T15:56:33Z

Should I copy those from the master branch to my branch?

This is where I think a manual rebase + squash could be helpful. I can help with that if needed.

Thank you @sftim could you help me to do that?

sftim · 2020-09-16T17:15:02Z

Thank you @sftim could you help me to do that?

Let's get the (virtual) paperwork in place first, then I can use my access as tech lead to take care of it all.

kasramp · 2020-09-16T19:59:44Z

/lgtm

sftim · 2020-09-16T22:04:32Z

@sattarfeizollahibarough I have force-pushed dev-1.18-fa.1 as discussed.

If you visit https://github.com/kubernetes/website/pull/new/dev-1.18-fa.1 you can open a pull request (I suggest you mark it as work-in-progress) to merge that into master

k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 17, 2020

k8s-ci-robot requested review from celestehorgan and makoscafee July 17, 2020 20:07

k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Jul 17, 2020

rlenferink reviewed Jul 18, 2020

View reviewed changes

OWNERS_ALIASES Outdated Show resolved Hide resolved

content/fa/OWNERS Show resolved Hide resolved

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 19, 2020

sattarfgh requested a review from rlenferink July 19, 2020 09:24

k8s-ci-robot changed the title ~~Persian language~~ Add فارسی (Persian) localization Jul 19, 2020

k8s-ci-robot changed the title ~~Add فارسی (Persian) localization~~ [WIP] Add فارسی (Persian) localization Jul 20, 2020

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 20, 2020

sftim mentioned this pull request Jul 20, 2020

Added label for Persian language kubernetes/test-infra#18369

Merged

zacharysarah previously requested changes Jul 21, 2020

View reviewed changes

OWNERS_ALIASES Outdated Show resolved Hide resolved

content/fa/OWNERS Show resolved Hide resolved

zacharysarah mentioned this pull request Jul 21, 2020

REQUEST: New Slack channel kubernetes-docs-fa kubernetes/community#4979

Closed

This was referenced Jul 21, 2020

added persian team members. kubernetes/org#2051

Closed

REQUEST: New membership for sattarfeizollahibarough kubernetes/org#2058

Closed

sftim mentioned this pull request Jul 25, 2020

Localize website into Persian (fa) #22727

Closed

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2020

kbhawkey reviewed Sep 16, 2020

View reviewed changes

config.toml Outdated Show resolved Hide resolved

kbhawkey reviewed Sep 16, 2020

View reviewed changes

Update config.toml

4cfeba6

kbhawkey reviewed Sep 16, 2020

View reviewed changes

k8s-ci-robot assigned kasramp Sep 16, 2020

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 16, 2020

k8s-ci-robot merged commit 3bfcee3 into kubernetes:dev-1.18-fa.1 Sep 16, 2020

seokho-son mentioned this pull request Jul 22, 2024

Localize Kubernetes website into Farsi #47142

Open

16 tasks

		@@ -0,0 +1 @@
		<svg id="Layer_1" data-name="Layer 1" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 214 210"><defs><style>.cls-1{fill:#316ce6;}.cls-2{fill:#09c1d1;}.cls-3{fill:#c9e9ec;}</style></defs><title>kubernetes_icons</title><rect class="cls-1" x="10.24" y="8.775" width="33.6" height="33.6" rx="4.158"/><rect class="cls-1" x="10.24" y="46.975" width="33.6" height="33.6" rx="4.158"/><rect class="cls-1" x="170.2" y="8.775" width="33.6" height="33.6" rx="4.158"/><rect class="cls-1" x="90.18" y="86.925" width="33.6" height="33.6" rx="4.158"/><rect class="cls-1" x="50.23" y="126.825" width="33.6" height="33.6" rx="4.158"/><rect class="cls-1" x="10.24" y="166.085" width="33.6" height="33.6" rx="4.158"/><rect class="cls-1" x="90.22" y="166.085" width="33.6" height="33.6" rx="4.158"/><rect class="cls-2" x="89.99" y="8.775" width="33.6" height="33.6" rx="4.158"/><rect class="cls-3" x="89.99" y="48.1" width="33.6" height="33.6" rx="4.158"/><rect class="cls-3" x="49.914" y="8.775" width="33.6" height="33.6" rx="4.158"/><rect class="cls-3" x="10.24" y="86.925" width="33.6" height="33.6" rx="4.158"/><rect class="cls-3" x="50.23" y="166.085" width="33.6" height="33.6" rx="4.158"/><rect class="cls-3" x="130.21" y="126.825" width="33.6" height="33.6" rx="4.158"/><rect class="cls-3" x="170.2" y="166.085" width="33.6" height="33.6" rx="4.158"/><rect class="cls-2" x="49.914" y="48.1" width="33.6" height="33.6" rx="4.158"/><rect class="cls-2" x="50.21" y="86.925" width="33.6" height="33.6" rx="4.158"/><rect class="cls-2" x="130.15" y="86.925" width="33.6" height="33.6" rx="4.158"/><rect class="cls-2" x="170.2" y="126.825" width="33.6" height="33.6" rx="4.158"/><rect class="cls-2" x="10.24" y="126.825" width="33.6" height="33.6" rx="4.158"/><rect class="cls-2" x="130.21" y="166.085" width="33.6" height="33.6" rx="4.158"/><rect class="cls-2" x="90.22" y="126.825" width="33.6" height="33.6" rx="4.158"/></svg>

Kick off فارسی (Persian) localization #22565

Kick off فارسی (Persian) localization #22565

Conversation

sattarfgh commented Jul 17, 2020

k8s-ci-robot commented Jul 17, 2020

netlify bot commented Jul 17, 2020 • edited Loading

rlenferink left a comment

Choose a reason for hiding this comment

sftim commented Jul 19, 2020

sftim commented Jul 19, 2020

sattarfgh commented Jul 20, 2020

sftim commented Jul 20, 2020

sftim commented Jul 20, 2020

sattarfgh commented Jul 20, 2020

zacharysarah left a comment

Choose a reason for hiding this comment

kasramp commented Jul 25, 2020

sattarfgh commented Jul 25, 2020

sftim commented Jul 25, 2020

sftim commented Sep 16, 2020

k8s-ci-robot commented Sep 16, 2020

sftim commented Sep 16, 2020

kbhawkey Sep 16, 2020

Choose a reason for hiding this comment

sftim commented Sep 16, 2020

kbhawkey Sep 16, 2020

Choose a reason for hiding this comment

kbhawkey commented Sep 16, 2020

kbhawkey commented Sep 16, 2020

kbhawkey commented Sep 16, 2020

sftim commented Sep 16, 2020

kbhawkey commented Sep 16, 2020

kbhawkey commented Sep 16, 2020

sattarfgh commented Sep 16, 2020

sattarfgh commented Sep 16, 2020 • edited Loading

sattarfgh commented Sep 16, 2020

kbhawkey Sep 16, 2020

Choose a reason for hiding this comment

sattarfgh Sep 16, 2020 • edited Loading

Choose a reason for hiding this comment

kbhawkey Sep 16, 2020

Choose a reason for hiding this comment

kbhawkey commented Sep 16, 2020

sattarfgh commented Sep 16, 2020

sftim commented Sep 16, 2020 • edited Loading

sattarfgh commented Sep 16, 2020

sftim commented Sep 16, 2020

kasramp commented Sep 16, 2020

sftim commented Sep 16, 2020

netlify bot commented Jul 17, 2020 •

edited

Loading

sattarfgh commented Sep 16, 2020 •

edited

Loading

sattarfgh Sep 16, 2020 •

edited

Loading

sftim commented Sep 16, 2020 •

edited

Loading