Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

releases: Update patch release schedule and add Release Manager info #27997

Merged
merged 9 commits into from
May 20, 2021

Conversation

justaugustus
Copy link
Member

@justaugustus justaugustus commented May 15, 2021

Continuation of @jimangel's wonderful work in #27929.

  • OWNERS: Update SIG Release content reviewers/approvers
  • scripts: Allow SIG Release to approve changes to update-release-info
  • releases: Canonicalize patch release information on k/website
  • releases: Canonicalize Release Managers page on k/website
  • release-managers: Update personnel
  • release-managers: Link cleanup
  • patch-releases: Update cycle after May releases and EOL 1.18 (supersedes patch/schedule: update patche schedule for June cycle sig-release#1570, FYI @cpanato)

Signed-off-by: Stephen Augustus foo@auggie.dev

/hold for:

cc: @kubernetes/sig-release-leads @kubernetes/release-engineering

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 15, 2021
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 15, 2021
@justaugustus justaugustus changed the title [WIP] Patch release releases: Update patch release schedule and add Release Manager info May 15, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 15, 2021
@justaugustus
Copy link
Member Author

/assign @saschagrunert @hasheddan @jeremyrickard @jimangel
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 15, 2021
@justaugustus
Copy link
Member Author

/cc @sftim

@k8s-ci-robot k8s-ci-robot requested a review from sftim May 15, 2021 20:50
@netlify
Copy link

netlify bot commented May 15, 2021

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 8648392

https://deploy-preview-27997--kubernetes-io-master-staging.netlify.app

@netlify
Copy link

netlify bot commented May 15, 2021

Deploy Preview for kubernetes-io-master-staging ready!

Built with commit 2021ada

https://deploy-preview-27997--kubernetes-io-master-staging.netlify.app

@jimangel
Copy link
Member

/lgtm
/approve

Good call on moving the script, I look forward to the day we delete it all together! I think everything in this PR is fine as we continue iterating on what the releases page looks like.

Is the schedule still pending?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 15, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 183c898e44dbe919a3207fa07200374a193fcefc

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2021
@justaugustus
Copy link
Member Author

Good call on moving the script, I look forward to the day we delete it all together!

Hehe, I was considering removing in this pass, but I want to noodle more on where the last page should go, since it's currently in k/community.

Ultimately, it may end up being a better fit in k8s.dev.

Is the schedule still pending?

Yep. We'll let @kubernetes/release-engineering review next week before merging.

@jeremyrickard
Copy link
Contributor

/lgtm

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@irvifa irvifa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Comment on lines +1 to +4
---
title: Release Managers
type: docs
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this original documentation or duplicated from elsewhere? (It looks like it'd be a better fit for https://k8s.dev/)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sftim -- some of the other pages link out to the Release Managers contact info, so it feels right to keep them close.

The contact info also is needed by both contributors and external consumers, which makes it a better fit for k/website.

Comment on lines +83 to +84
| August 2021 | 2021-08-11 |
| September 2021 | 2021-09-15 |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have some rules that we're following for choosing the release day? I'm mostly wondering about August, since Wednesday after the 11th is the 18th, which seems like a reasonable release date as well. IIRC, we did releases on and around the 18th of the month in the past.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think those rules would be part of this PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think those rules would be part of this PR.

Agreed.
@xmudrii -- would you like to own discussing a policy as a follow-up action?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@justaugustus -- Sounds good. I'll take care of that.

Comment on lines +3 to +4
# release.md
####################################
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about other documents -- patch-releases.md and schedule.yaml? Are we permanently moving those two documents to this repo?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, there's an accompanying PR in k/sig-release here: kubernetes/sig-release#1577

@justaugustus justaugustus mentioned this pull request May 17, 2021
Comment on lines -4 to -12
auto_generated: true
---
<!-- THIS CONTENT IS AUTO-GENERATED via ./scripts/update-release-info.sh in k/website -->

{{< warning >}}
This content is auto-generated and links may not function. The source of the document is located [here](https://github.com/kubernetes/sig-release/blob/master/releases/patch-releases.md).
{{< /warning >}}

# Kubernetes Patch Releases
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume we deprecate https://github.com/kubernetes/sig-release/blob/master/releases/patch-releases.md and link it into this location, right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we edit https://github.com/kubernetes/sig-release/blob/master/releases/patch-releases.md to mention deprecation or a link to the canonical page, we'll need to automate removing that deprecation text / link from the copy on https://kubernetes.io/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I'm fine with doing that, but it'd need to happen)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sftim @saschagrunert -- That's the plan! (mentioned in the PR description)

* releases: Canonicalize patch release information on k/website
* releases: Canonicalize Release Managers page on k/website

/hold for:

* [ ]  discussion
* [ ]  approval of future patch schedule
* [ ]  accompanying tombstones in k/sig-release

The script has already been updated in support of that (ref: 39796d1).
Tombstones to follow.

justaugustus and others added 9 commits May 19, 2021 17:04
Signed-off-by: Stephen Augustus <foo@auggie.dev>
Signed-off-by: Stephen Augustus <foo@auggie.dev>
Signed-off-by: Stephen Augustus <foo@auggie.dev>
Signed-off-by: Stephen Augustus <foo@auggie.dev>
Signed-off-by: Stephen Augustus <foo@auggie.dev>
Signed-off-by: Stephen Augustus <foo@auggie.dev>
Signed-off-by: Stephen Augustus <foo@auggie.dev>
Co-authored-by: Carlos Panato <ctadeu@gmail.com>
Signed-off-by: Stephen Augustus <foo@auggie.dev>
Signed-off-by: Stephen Augustus <foo@auggie.dev>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 19, 2021
@justaugustus
Copy link
Member Author

justaugustus commented May 19, 2021

@kubernetes/sig-release-leads @sftim --

I've added tombstones to de-dupe the page content here: kubernetes/sig-release#1577
Will follow-up with the area/release-eng label later today.

@wilsonehusin -- Nice catch on script location!

@kubernetes/release-engineering -- How are we feeling about the proposed dates?

All -- anything else that needs review here?

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dates lgtm
and thanks for all this!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 20, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f0abc4e347f97acf628d63cc2ecef520f466d526

Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@justaugustus
Copy link
Member Author

Thanks everyone!
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 20, 2021
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, jimangel, saschagrunert, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 726587e into kubernetes:master May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet