-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
releases: Update patch release schedule and add Release Manager info #27997
Conversation
8648392
to
fc5f99a
Compare
/assign @saschagrunert @hasheddan @jeremyrickard @jimangel |
/cc @sftim |
Deploy preview for kubernetes-io-master-staging ready! Built with commit 8648392 https://deploy-preview-27997--kubernetes-io-master-staging.netlify.app |
Deploy Preview for kubernetes-io-master-staging ready! Built with commit 2021ada https://deploy-preview-27997--kubernetes-io-master-staging.netlify.app |
/lgtm Good call on moving the script, I look forward to the day we delete it all together! I think everything in this PR is fine as we continue iterating on what the releases page looks like. Is the schedule still pending? |
LGTM label has been added. Git tree hash: 183c898e44dbe919a3207fa07200374a193fcefc
|
Hehe, I was considering removing in this pass, but I want to noodle more on where the last page should go, since it's currently in k/community. Ultimately, it may end up being a better fit in k8s.dev.
Yep. We'll let @kubernetes/release-engineering review next week before merging. |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
--- | ||
title: Release Managers | ||
type: docs | ||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this original documentation or duplicated from elsewhere? (It looks like it'd be a better fit for https://k8s.dev/)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sftim -- some of the other pages link out to the Release Managers contact info, so it feels right to keep them close.
The contact info also is needed by both contributors and external consumers, which makes it a better fit for k/website.
| August 2021 | 2021-08-11 | | ||
| September 2021 | 2021-09-15 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have some rules that we're following for choosing the release day? I'm mostly wondering about August, since Wednesday after the 11th is the 18th, which seems like a reasonable release date as well. IIRC, we did releases on and around the 18th of the month in the past.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think those rules would be part of this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think those rules would be part of this PR.
Agreed.
@xmudrii -- would you like to own discussing a policy as a follow-up action?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@justaugustus -- Sounds good. I'll take care of that.
# release.md | ||
#################################### |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about other documents -- patch-releases.md
and schedule.yaml
? Are we permanently moving those two documents to this repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, there's an accompanying PR in k/sig-release here: kubernetes/sig-release#1577
auto_generated: true | ||
--- | ||
<!-- THIS CONTENT IS AUTO-GENERATED via ./scripts/update-release-info.sh in k/website --> | ||
|
||
{{< warning >}} | ||
This content is auto-generated and links may not function. The source of the document is located [here](https://github.com/kubernetes/sig-release/blob/master/releases/patch-releases.md). | ||
{{< /warning >}} | ||
|
||
# Kubernetes Patch Releases |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume we deprecate https://github.com/kubernetes/sig-release/blob/master/releases/patch-releases.md and link it into this location, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we edit https://github.com/kubernetes/sig-release/blob/master/releases/patch-releases.md to mention deprecation or a link to the canonical page, we'll need to automate removing that deprecation text / link from the copy on https://kubernetes.io/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I'm fine with doing that, but it'd need to happen)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sftim @saschagrunert -- That's the plan! (mentioned in the PR description)
* releases: Canonicalize patch release information on k/website * releases: Canonicalize Release Managers page on k/website
/hold for:
* [ ] discussion * [ ] approval of future patch schedule * [ ] accompanying tombstones in k/sig-release
The script has already been updated in support of that (ref: 39796d1).
Tombstones to follow.
Signed-off-by: Stephen Augustus <foo@auggie.dev>
Signed-off-by: Stephen Augustus <foo@auggie.dev>
Signed-off-by: Stephen Augustus <foo@auggie.dev>
Signed-off-by: Stephen Augustus <foo@auggie.dev>
Signed-off-by: Stephen Augustus <foo@auggie.dev>
Signed-off-by: Stephen Augustus <foo@auggie.dev>
Signed-off-by: Stephen Augustus <foo@auggie.dev> Co-authored-by: Carlos Panato <ctadeu@gmail.com>
Signed-off-by: Stephen Augustus <foo@auggie.dev>
Signed-off-by: Stephen Augustus <foo@auggie.dev>
fc5f99a
to
2021ada
Compare
@kubernetes/sig-release-leads @sftim -- I've added tombstones to de-dupe the page content here: kubernetes/sig-release#1577 @wilsonehusin -- Nice catch on script location! @kubernetes/release-engineering -- How are we feeling about the proposed dates? All -- anything else that needs review here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dates lgtm
and thanks for all this!
/lgtm
LGTM label has been added. Git tree hash: f0abc4e347f97acf628d63cc2ecef520f466d526
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks everyone! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, jimangel, saschagrunert, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Continuation of @jimangel's wonderful work in #27929.
Signed-off-by: Stephen Augustus foo@auggie.dev
/hold for:
area/release-eng
label to k/website: label_sync(releng): Add area/release-eng label to kubernetes/website test-infra#22272cc: @kubernetes/sig-release-leads @kubernetes/release-engineering