Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redirect pointers to kubeadm config #28862

Closed
wants to merge 1 commit into from
Closed

Redirect pointers to kubeadm config #28862

wants to merge 1 commit into from

Conversation

tengqm
Copy link
Contributor

@tengqm tengqm commented Jul 8, 2021 •
edited
Loading

This PR redirects pointers of kubeadm config to the generated reference rather than the godoc site. Where appropriate, references to v1beta2 are replaced by v1beta3.

This one follows the #28775 PR.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 8, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from tengqm after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jul 8, 2021
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jul 8, 2021
@tengqm
Redirect pointers to kubeadm config
b76d53d 
This PR redirects pointers of kubeadm config to the generated reference
rather than the godoc site. Where appropriate, references to v1beta2
are replaced by v1beta3.
@tengqm tengqm force-pushed the redirect-kubeadm-config branch from b61fad3 to b76d53d Compare July 8, 2021 13:56
@tengqm
Copy link
Contributor Author

tengqm commented Jul 8, 2021

/hold
Maybe this one should target dev-1.22 since v1beta3 is only for 1.22.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2021
@tengqm
Copy link
Contributor Author

tengqm commented Jul 8, 2021

oops, will conflict with #28360.
Will fix this problem after that one is in.

@tengqm
Copy link
Contributor Author

tengqm commented Jul 8, 2021

/close

@k8s-ci-robot
Copy link
Contributor

@tengqm: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@netlify
Copy link

netlify bot commented Jul 8, 2021

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: b61fad3

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/60e703cfeca62300080593e2

😎 Browse the preview: https://deploy-preview-28862--kubernetes-io-main-staging.netlify.app

@netlify
Copy link

netlify bot commented Jul 8, 2021

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: b76d53d

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/60e7041b783494000717bfa8

😎 Browse the preview: https://deploy-preview-28862--kubernetes-io-main-staging.netlify.app

@neolit123 neolit123 mentioned this pull request Jul 8, 2021
Merged
@PI-Victor
Copy link
Member

sorry, i did approve for merge but didn't notice there was a hold on that PR, it's now merged, please feel free to reopen whenever you have the time.

@tengqm tengqm deleted the redirect-kubeadm-config branch July 18, 2021 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steveperry-53 steveperry-53 Awaiting requested review from steveperry-53

@zparnold zparnold Awaiting requested review from zparnold

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tengqm @k8s-ci-robot @PI-Victor