Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubeadm: use k8s-staging-ci-images instead of kubernetes-ci-images #29159

Merged
merged 1 commit into from
Aug 3, 2021

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Jul 30, 2021

Related:

This replacement is technically capable of being backported to the v1.21
and v1.22 docs based on when the change it's documenting landed, but I
don't feel strongly that it needs to. The old default repo has still been
populated with ci builds through v1.22. This only truly matters for v1.23,
as that's when we stopped landing builds in the (incorrect as of v1.21)
old default.

@spiffxp
Copy link
Member Author

spiffxp commented Jul 30, 2021

/cc @neolit123

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 30, 2021
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 30, 2021
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jul 30, 2021
@k8s-ci-robot k8s-ci-robot added language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jul 30, 2021
@netlify
Copy link

netlify bot commented Jul 30, 2021

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: be9926d

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/610351adc7518500077f1817

😎 Browse the preview: https://deploy-preview-29159--kubernetes-io-main-staging.netlify.app

Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks
/lgtm
/sig cluster-lifecycle

@k8s-ci-robot k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Jul 30, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 30, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b38ac60cccd28b64ccc74ea80a93b779d9d8ad43

@neolit123
Copy link
Member

/assign @tengqm

@chenxuc
Copy link
Contributor

chenxuc commented Jul 30, 2021

thanks
/lgtm

@reylejano
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2021
@k8s-ci-robot k8s-ci-robot merged commit a54e81e into kubernetes:main Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language language/fr Issues or PRs related to French language language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants