-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add introductions for scheduler component config api migrations #30151
add introductions for scheduler component config api migrations #30151
Conversation
@alculquicondor PTAL, thanks. |
✔️ Deploy Preview for kubernetes-io-main-staging ready! 🔨 Explore the source changes: c0175c5 🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/61834121a878e10007495e70 😎 Browse the preview: https://deploy-preview-30151--kubernetes-io-main-staging.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HI @kerthcet
Please can you exclude the changes to the api-ref-generator
and docsy
submodules from this PR? It might be enough to rebase against the current main branch from this repo.
If you'd like more Git advice, reply and we can suggest some steps.
Also, I've added some inline feedback about headings.
An alternative to different headings for each different target config version: tabs. I think that's what I'd use. |
sorry about the unrelated commits, I'll revert them. |
ee4b985
to
1947731
Compare
837f241
to
5c51a5b
Compare
I'll create another pr about the |
/unhold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's some feedback on the wording and use of Markdown.
I hope the examples I've added make sense; if not, please do ask questions.
5c51a5b
to
2c21e6d
Compare
/lgtm |
LGTM label has been added. Git tree hash: dcef7ce8789c689846760eba2009fb937dcbd4a9
|
kindly ping @sftim |
/assign @jlbutler |
bef5849
to
bbd7abf
Compare
reopen for mis-operations and squashed all the commits. |
Signed-off-by: kerthcet <kerthcet@gmail.com>
9f1896a
to
c0175c5
Compare
/lgtm |
LGTM label has been added. Git tree hash: 6bef17592b6aaeba1b566d90b2f63d7621d64adf
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bezzo100-lab, tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: kerthcet kerthcet@gmail.com
xref: #30063
part of: kubernetes/enhancements#2901