Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add introductions for scheduler component config api migrations #30151

Merged
merged 1 commit into from
Nov 5, 2021
Merged

add introductions for scheduler component config api migrations #30151

merged 1 commit into from
Nov 5, 2021

Conversation

kerthcet
Copy link
Member

@kerthcet kerthcet commented Oct 20, 2021 •
edited

Signed-off-by: kerthcet kerthcet@gmail.com

xref: #30063
part of: kubernetes/enhancements#2901

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 20, 2021
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Oct 20, 2021
@kerthcet
Copy link
Member Author

@alculquicondor PTAL, thanks.
/hold waiting for the Cleanup/remove service affinity plugin to be merged as mentioned in this commit.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 20, 2021
@kerthcet kerthcet mentioned this pull request Oct 20, 2021
Closed
8 tasks
@netlify
Copy link

netlify bot commented Oct 20, 2021 •
edited

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: c0175c5

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/61834121a878e10007495e70

😎 Browse the preview: https://deploy-preview-30151--kubernetes-io-main-staging.netlify.app

sftim
sftim previously requested changes Oct 20, 2021
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI @kerthcet

Please can you exclude the changes to the api-ref-generator and docsy submodules from this PR? It might be enough to rebase against the current main branch from this repo.

If you'd like more Git advice, reply and we can suggest some steps.

Also, I've added some inline feedback about headings.

content/en/docs/reference/scheduling/config.md Outdated Show resolved Hide resolved
content/en/docs/reference/scheduling/config.md Outdated Show resolved Hide resolved
content/en/docs/reference/scheduling/config.md Outdated Show resolved Hide resolved
@sftim
Copy link
Contributor

sftim commented Oct 20, 2021

An alternative to different headings for each different target config version: tabs. I think that's what I'd use.

@kerthcet
Copy link
Member Author

sorry about the unrelated commits, I'll revert them.

@kerthcet kerthcet force-pushed the feature/add-introduce-to-scheduler-v1beta3 branch from ee4b985 to 1947731 Compare October 20, 2021 08:29
alculquicondor
alculquicondor reviewed Oct 20, 2021
View reviewed changes
content/en/docs/reference/scheduling/config.md Show resolved Hide resolved
content/en/docs/reference/scheduling/config.md Show resolved Hide resolved
content/en/docs/reference/scheduling/config.md Outdated Show resolved Hide resolved
content/en/docs/reference/scheduling/config.md Outdated Show resolved Hide resolved
content/en/docs/reference/scheduling/config.md Outdated Show resolved Hide resolved
content/en/docs/reference/scheduling/config.md Outdated Show resolved Hide resolved
content/en/docs/reference/scheduling/config.md Outdated Show resolved Hide resolved
@kerthcet kerthcet force-pushed the feature/add-introduce-to-scheduler-v1beta3 branch 4 times, most recently from 837f241 to 5c51a5b Compare October 21, 2021 08:19
@kerthcet
Copy link
Member Author

kerthcet commented Oct 21, 2021 •
edited

I'll create another pr about the v1beta2 -> v1beta3 changes to dev-1.23 later

@kerthcet
Copy link
Member Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 21, 2021
sftim
sftim reviewed Oct 21, 2021
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's some feedback on the wording and use of Markdown.

I hope the examples I've added make sense; if not, please do ask questions.

content/en/docs/reference/scheduling/config.md Outdated Show resolved Hide resolved
content/en/docs/reference/scheduling/config.md Outdated Show resolved Hide resolved
content/en/docs/reference/scheduling/config.md Outdated Show resolved Hide resolved
content/en/docs/reference/scheduling/config.md Outdated Show resolved Hide resolved
content/en/docs/reference/scheduling/config.md Outdated Show resolved Hide resolved
@sftim sftim dismissed their stale review October 21, 2021 11:11

Feedback was addressed

@kerthcet kerthcet force-pushed the feature/add-introduce-to-scheduler-v1beta3 branch from 5c51a5b to 2c21e6d Compare October 21, 2021 15:23
alculquicondor
alculquicondor reviewed Oct 21, 2021
View reviewed changes
content/en/docs/reference/scheduling/config.md Outdated Show resolved Hide resolved
content/en/docs/reference/scheduling/config.md Outdated Show resolved Hide resolved
content/en/docs/reference/scheduling/config.md Outdated Show resolved Hide resolved
content/en/docs/reference/scheduling/config.md Outdated Show resolved Hide resolved
content/en/docs/reference/scheduling/config.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 26, 2021
@alculquicondor
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 26, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: dcef7ce8789c689846760eba2009fb937dcbd4a9

@kerthcet
Copy link
Member Author

kindly ping @sftim

@alculquicondor
Copy link
Member

/assign @jlbutler

@kbhawkey
Copy link
Contributor

kbhawkey commented Nov 4, 2021

Page preview:
https://deploy-preview-30151--kubernetes-io-main-staging.netlify.app/docs/reference/scheduling/config/

@kerthcet kerthcet closed this Nov 4, 2021
@kerthcet kerthcet force-pushed the feature/add-introduce-to-scheduler-v1beta3 branch from bef5849 to bbd7abf Compare November 4, 2021 01:55
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 4, 2021
@kerthcet
Copy link
Member Author

kerthcet commented Nov 4, 2021

reopen for mis-operations and squashed all the commits.

@kerthcet kerthcet reopened this Nov 4, 2021
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 4, 2021
@kerthcet
add introductions for scheduler component config api migrations
c0175c5 
Signed-off-by: kerthcet <kerthcet@gmail.com>
@kerthcet kerthcet force-pushed the feature/add-introduce-to-scheduler-v1beta3 branch from 9f1896a to c0175c5 Compare November 4, 2021 02:10
@alculquicondor
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 4, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6bef17592b6aaeba1b566d90b2f63d7621d64adf

@tengqm
Copy link
Contributor

tengqm commented Nov 5, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bezzo100-lab, tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2021
@k8s-ci-robot k8s-ci-robot merged commit ff7a649 into kubernetes:main Nov 5, 2021
@kerthcet kerthcet deleted the feature/add-introduce-to-scheduler-v1beta3 branch November 5, 2021 01:05
@kerthcet kerthcet mentioned this pull request Nov 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@kbhawkey kbhawkey kbhawkey left review comments

@sftim sftim sftim left review comments

@Bezzo100-lab Bezzo100-lab Bezzo100-lab approved these changes

@rajeshdeshpande02 rajeshdeshpande02 Awaiting requested review from rajeshdeshpande02

Assignees

@alculquicondor alculquicondor

@jlbutler jlbutler

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@kerthcet @sftim @k8s-ci-robot @alculquicondor @kbhawkey @tengqm @Bezzo100-lab @jlbutler