-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generic ephemeral volume GA #30361
generic ephemeral volume GA #30361
Conversation
👷 Deploy Preview for kubernetes-io-vnext-staging processing. 🔨 Explore the source changes: 65bceb1 🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/618e29ea808d810007883089 |
44bc005
to
ae0e19d
Compare
/lgtm |
LGTM label has been added. Git tree hash: 8b8a4c2428de73a9ece9a78d148a746c5f0bf5c6
|
@@ -245,7 +244,6 @@ PVCs indirectly if they can create Pods, even if they do not have | |||
permission to create PVCs directly. Cluster administrators must be | |||
aware of this. If this does not fit their security model, they have | |||
two choices: | |||
- Explicitly disable the feature through the feature gate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still possible though not encouraged, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it's locked to enabled when the feature graduates to GA.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it.
/assign @ramrodo |
/lgtm |
/assign @sftim For approval. |
@@ -130,10 +130,9 @@ As a cluster administrator, you can use a [PodSecurityPolicy](/docs/concepts/pol | |||
|
|||
### Generic ephemeral volumes | |||
|
|||
{{< feature-state for_k8s_version="v1.19" state="alpha" >}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @pohly . The changes look good.
Can you remove the feature state shortcodes for the alpha and beta states? (lines 133 and 134).
You can list the stable version. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've amended the commit: https://github.com/kubernetes/website/compare/ae0e19db9ed7e31a4025034b3d127e276e17a301..65bceb18762f0c182dbbc50d9dfbeb478fcccc03
Please take another look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ae0e19d
to
65bceb1
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks @pohly . |
LGTM label has been added. Git tree hash: 4b4ab86e8381c4fb7b569931d3275978a150f294
|
The feature was graduated to GA for 1.23: kubernetes/kubernetes#105609