Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generic ephemeral volume GA #30361

Merged
merged 1 commit into from
Nov 13, 2021
Merged

generic ephemeral volume GA #30361

merged 1 commit into from
Nov 13, 2021

Conversation

pohly
Copy link
Contributor

@pohly pohly commented Nov 4, 2021

The feature was graduated to GA for 1.23: kubernetes/kubernetes#105609

@k8s-ci-robot k8s-ci-robot added this to the 1.23 milestone Nov 4, 2021
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 4, 2021
@netlify
Copy link

netlify bot commented Nov 4, 2021 •
edited

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

🔨 Explore the source changes: 65bceb1

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/618e29ea808d810007883089

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 4, 2021
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Nov 4, 2021
@pohly pohly mentioned this pull request Nov 4, 2021
Closed
@pohly pohly force-pushed the generic-ephemeral-volumes-ga branch from 44bc005 to ae0e19d Compare November 4, 2021 14:10
@msau42
Copy link
Member

msau42 commented Nov 4, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 4, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8b8a4c2428de73a9ece9a78d148a746c5f0bf5c6

@pohly pohly changed the title generic ephemeral volume GW generic ephemeral volume GA Nov 4, 2021
tengqm
tengqm reviewed Nov 5, 2021
View reviewed changes
content/en/docs/concepts/storage/ephemeral-volumes.md
@@ -245,7 +244,6 @@ PVCs indirectly if they can create Pods, even if they do not have
permission to create PVCs directly. Cluster administrators must be
aware of this. If this does not fit their security model, they have
two choices:
- Explicitly disable the feature through the feature gate.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still possible though not encouraged, right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's locked to enabled when the feature graduates to GA.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it.

@jlbutler
Copy link
Contributor

jlbutler commented Nov 5, 2021

/assign @ramrodo

@ramrodo
Copy link
Member

ramrodo commented Nov 5, 2021

/lgtm

@pohly
Copy link
Contributor Author

pohly commented Nov 10, 2021

/assign @sftim

For approval.

kbhawkey
kbhawkey reviewed Nov 11, 2021
View reviewed changes
content/en/docs/concepts/storage/ephemeral-volumes.md Outdated
@@ -130,10 +130,9 @@ As a cluster administrator, you can use a [PodSecurityPolicy](/docs/concepts/pol

### Generic ephemeral volumes

{{< feature-state for_k8s_version="v1.19" state="alpha" >}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pohly . The changes look good.
Can you remove the feature state shortcodes for the alpha and beta states? (lines 133 and 134).
You can list the stable version. Thanks.

Copy link
Contributor Author

@pohly pohly Nov 12, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've amended the commit: https://github.com/kubernetes/website/compare/ae0e19db9ed7e31a4025034b3d127e276e17a301..65bceb18762f0c182dbbc50d9dfbeb478fcccc03

Please take another look.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msau42, @kbhawkey: Can I get an new LGTM?

@pohly pohly force-pushed the generic-ephemeral-volumes-ga branch from ae0e19d to 65bceb1 Compare November 12, 2021 08:46
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 12, 2021
@tengqm
Copy link
Contributor

tengqm commented Nov 13, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2021
@kbhawkey
Copy link
Contributor

Thanks @pohly .
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4b4ab86e8381c4fb7b569931d3275978a150f294

@k8s-ci-robot k8s-ci-robot merged commit 1466530 into kubernetes:dev-1.23 Nov 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbhawkey kbhawkey kbhawkey left review comments

@tengqm tengqm tengqm left review comments

@msau42 msau42 msau42 left review comments

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@kbhawkey kbhawkey

@ramrodo ramrodo

@sftim sftim

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.23
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@pohly @msau42 @k8s-ci-robot @jlbutler @ramrodo @tengqm @kbhawkey @sftim