Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add glossary entry for cadvisor #30830

Merged
merged 1 commit into from
Dec 10, 2021
Merged

Add glossary entry for cadvisor #30830

merged 1 commit into from
Dec 10, 2021

Conversation

markusheinemann
Copy link
Contributor

This PR introduces a new glossary entry for cadvisor. The glossary entry is used to explain this tool on the k8s.io/docs/concepts/architecture/garbage-collection/ page.

Resolves #30814

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Dec 9, 2021
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 9, 2021

CLA Signed

The committers are authorized under a signed CLA.

@k8s-ci-robot
Copy link
Contributor

Welcome @markusheinemann!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 9, 2021
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Dec 9, 2021
@netlify
Copy link

netlify bot commented Dec 9, 2021

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: a86ca5b

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/61b283f82d16bd000818e52f

😎 Browse the preview: https://deploy-preview-30830--kubernetes-io-main-staging.netlify.app

@sftim
Copy link
Contributor

sftim commented Dec 9, 2021

/check-cla
/easycla

@sftim
Copy link
Contributor

sftim commented Dec 9, 2021

We're migrating between CLA-signing systems. Could you follow the advice in #30830 (comment) @markusheinemann ?

@linux-foundation-easycla
Copy link

CLA Not Signed

@markusheinemann
Copy link
Contributor Author

/check-cla
/easycla

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 9, 2021

CLA Signed

The committers are authorized under a signed CLA.

@sftim
Copy link
Contributor

sftim commented Dec 9, 2021

@markusheinemann It's possible we don't have your GitHub username on record, or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits, matching an email address that GitHub recognizes as you.

@sftim
Copy link
Contributor

sftim commented Dec 9, 2021

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 9, 2021
@markusheinemann
Copy link
Contributor Author

Thanks for your support @sftim. Should be fine now 😃

@sftim
Copy link
Contributor

sftim commented Dec 10, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 10, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 48bdff484fc5c6277afaf9ba4814fc212a4d466d

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2021
@k8s-ci-robot k8s-ci-robot merged commit bec8398 into kubernetes:main Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvement for k8s.io/docs/concepts/architecture/garbage-collection/
3 participants