vSphere Storage Policy Based Management for Containers orchestrated b… #3219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
BaluDontu
force-pushed
the
VSANPolicyDocumentation
branch
from
47c791a
to
deaf67e
Compare
chenopis
suggested changes
Apr 12, 2017
| @@ -505,6 +505,7 @@ parameters: | |||
|
|
|||
| #### vSphere | |||
|
|
|||
| 1. Create a persistent volume with a user specified disk format. | |||
There was a problem hiding this comment.
These are not being rendered correctly as a numbered list. Indent the material between the numbered items to maintain the incremental numbering.
| datastore: VSANDatastore | ||
| ``` | ||
|
|
||
| * `diskformat`: `thin`, `zeroedthick` and `eagerzeroedthick`. Default: `"thin"`. |
There was a problem hiding this comment.
If these are bulleted items under the numbered item, add an additional indent before each one.
BaluDontu
force-pushed
the
VSANPolicyDocumentation
branch
3 times, most recently
from
1d87d6c
to
78afd22
Compare
|
@chenopis : Can you check the changes now. Thanks! |
chenopis
approved these changes
Apr 14, 2017
|
@BaluDontu Yup, looks good now. |
BaluDontu
force-pushed
the
VSANPolicyDocumentation
branch
from
78afd22
to
4d2eaa0
Compare
|
@BaluDontu We still need a Tech LGTM from @saad-ali or @mikedanese, but after that I can merge this. |
|
tech lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added documentation for VSAN policy based support for persistent volume provisioning inside kubernetes.
This document references to the fix kubernetes/kubernetes#42974.
CC @divyenpatel @tusharnt
This change is