-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vSphere Storage Policy Based Management for Containers orchestrated b… #3219
Conversation
47c791a
to
deaf67e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor formatting issues.
@@ -505,6 +505,7 @@ parameters: | |||
|
|||
#### vSphere | |||
|
|||
1. Create a persistent volume with a user specified disk format. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are not being rendered correctly as a numbered list. Indent the material between the numbered items to maintain the incremental numbering.
datastore: VSANDatastore | ||
``` | ||
|
||
* `diskformat`: `thin`, `zeroedthick` and `eagerzeroedthick`. Default: `"thin"`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If these are bulleted items under the numbered item, add an additional indent before each one.
1d87d6c
to
78afd22
Compare
@chenopis : Can you check the changes now. Thanks! |
@BaluDontu Yup, looks good now. |
78afd22
to
4d2eaa0
Compare
@BaluDontu We still need a Tech LGTM from @saad-ali or @mikedanese, but after that I can merge this. |
tech lgtm |
Added documentation for VSAN policy based support for persistent volume provisioning inside kubernetes.
This document references to the fix kubernetes/kubernetes#42974.
CC @divyenpatel @tusharnt
This change is![Reviewable](https://camo.githubusercontent.com/bdad2d5a4be7a00dc3b2426ea57eabd73ef84d8ed5ee05653b2f1501b6ea93ab/68747470733a2f2f72657669657761626c652e6b756265726e657465732e696f2f7265766965775f627574746f6e2e737667)