Add documentation for (alpha) feature ServiceIPStaticSubrange #32345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
sig/network
k8s-ci-robot
added
the
cncf-cla: yes
👷 Deploy Preview for kubernetes-io-vnext-staging processing.
|
k8s-ci-robot
added
the
size/XS
k8s-ci-robot
added
language/en
k8s-ci-robot
added
the
lgtm
|
/assign @nate-double-u |
sftim
requested changes
Mar 19, 2022
content/en/docs/reference/command-line-tools-reference/feature-gates.md
Outdated
Show resolved
Hide resolved
content/en/docs/reference/command-line-tools-reference/feature-gates.md
Outdated
Show resolved
Hide resolved
|
/lgtm cancel |
k8s-ci-robot
removed
the
lgtm
divya-mohan0209
requested changes
Mar 19, 2022
| @@ -1037,6 +1038,12 @@ Each feature gate is designed for enabling/disabling a specific feature: | |||
| topology of the cluster. See | |||
| [ServiceTopology](/docs/concepts/services-networking/service-topology/) | |||
| for more details. | |||
| - `ServiceIPStaticSubrange`: Enable a new strategy for Services ClusterIP allocations, so users can | |||
There was a problem hiding this comment.
Nit + adding on to Tim's suggestions above.
Suggested change
| - `ServiceIPStaticSubrange`: Enable a new strategy for Services ClusterIP allocations, so users can | |
| - `ServiceIPStaticSubrange`: Enables a strategy for Services ClusterIP allocations, whereby users can |
divya-mohan0209
requested changes
Mar 21, 2022
content/en/docs/reference/command-line-tools-reference/feature-gates.md
Outdated
Show resolved
Hide resolved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 4a2dae7c5a96c4d32185b8017cbc32daa9ac740c
|
k8s-ci-robot
removed
the
lgtm
k8s-ci-robot
added
the
size/S
aojea
commented
Mar 21, 2022
Comment on lines
1240
to
1250
| If you enable the `ServiceIPStaticSubrange` | ||
| [feature gate](/docs/reference/command-line-tools-reference/feature-gates/), | ||
| the allocation strategy subdivides the `ClusterIP` range in two bands, based on | ||
| the size of the configured `service-cluster-ip-range` by the following formula | ||
| `min(max(16, cidrSize / 16), 256)`, described as _never less than 16 or more than 256, | ||
| with a graduated step function between them_. Dynamic IP allocations will be preferently | ||
| chosen from the upper band, reducing risks of collisions with the IPs | ||
| assigned on the lower band. | ||
| This allows users to use the lower band of the `service-cluster-ip-range` for their | ||
| Services with static IPs assigned with a very low risk of collision. | ||
| {{< /note >}} |
There was a problem hiding this comment.
Replaced collision with conflict since the latter seems more appropriate, given the context
I do realize that collision has been used elsewhere in the K8s documentation and am not sure if the wording was intentional to keep it consistent across docs. Rest of it is slightly rephrased for clarity.
|
/label tide/merge-method-squash |
k8s-ci-robot
added
the
tide/merge-method-squash
tengqm
reviewed
Mar 29, 2022
content/en/docs/reference/command-line-tools-reference/feature-gates.md
Outdated
Show resolved
Hide resolved
|
/retitle Add documentation for (alpha) feature ServiceIPStaticSubrange |
k8s-ci-robot
changed the title
sftim
reviewed
Mar 29, 2022
| This allows users to use the lower band of the `service-cluster-ip-range` for their | ||
| Services with static IPs assigned with a very low risk of running into conflicts. | ||
| {{< /note >}} | ||
|
|
There was a problem hiding this comment.
We usually wouldn't put a feature gate shortcode inside a note. I'd use a 3rd-level (or maybe a 4th-level) heading here; for example:
#### IP address ranges for `type: ClusterIP` Services {#service-ip-static-sub-range}(and then skip the note callout entirely).
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tengqm, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
k8s-ci-robot
added
size/M
k8s-ci-robot
added
size/S
|
LGTM label has been added. Git tree hash: 15003b65552c2bc517b4807a31a62c59e796eca2
|
k8s-ci-robot
added
the
lgtm
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/sig network
KEP kubernetes/enhancements#3070