Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graduate JobReadyPods to beta #32396

Merged
merged 1 commit into from
Mar 30, 2022
Merged

Graduate JobReadyPods to beta #32396

merged 1 commit into from
Mar 30, 2022

Conversation

alculquicondor
Copy link
Member

@alculquicondor alculquicondor commented Mar 21, 2022 •
edited
Loading

Update the feature gates table. The only documentation for the feature is in the API field itself.

/sig apps

kubernetes/enhancements#2879

@k8s-ci-robot k8s-ci-robot added this to the 1.24 milestone Mar 21, 2022
@k8s-ci-robot k8s-ci-robot added the sig/apps Categorizes an issue or PR as relevant to SIG Apps. label Mar 21, 2022
@netlify
Copy link

netlify bot commented Mar 21, 2022

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

🔨 Explore the source changes: 3007ca4

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/6238d23d2fd5fb0008be71e3

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 21, 2022
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Mar 21, 2022
@alculquicondor alculquicondor mentioned this pull request Mar 21, 2022
Closed
14 tasks
sftim
sftim reviewed Mar 21, 2022
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is a minor detail and we don't document equivalent fields (eg status.readyReplicas), I think this is the only docs change required here.

LGTM.

@tengqm
Copy link
Contributor

tengqm commented Mar 22, 2022

/hold
Adding a hold for accidental merge before the upstream change kubernetes/kubernetes#107476 makes its way into 1.24.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 22, 2022
@mehabhalodiya
Copy link
Contributor

/assign

@tengqm
Copy link
Contributor

tengqm commented Mar 30, 2022

/hold cancel
Upstream code is in now.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 30, 2022
@tengqm
Copy link
Contributor

tengqm commented Mar 30, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 30, 2022
@kbhawkey
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 30, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8349ee91acd104f1ec31bb616cb1c7452670fb91

@k8s-ci-robot k8s-ci-robot merged commit ff563ae into kubernetes:dev-1.24 Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@bradtopol bradtopol Awaiting requested review from bradtopol

@daminisatya daminisatya Awaiting requested review from daminisatya

Assignees

@kbhawkey kbhawkey

@mehabhalodiya mehabhalodiya

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.24
Development

Successfully merging this pull request may close these issues.
6 participants
@alculquicondor @tengqm @mehabhalodiya @k8s-ci-robot @kbhawkey @sftim