-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document the MaxUnavailableStatefulSet feature #32596
Document the MaxUnavailableStatefulSet feature #32596
Conversation
👷 Deploy Preview for kubernetes-io-vnext-staging processing.
|
enhancement ref: kubernetes/enhancements#961 |
/sig apps |
i think there is more to document here for this feature |
@krmayankk It would be nice if you or someone can help provide more docs on this. |
a77f260
to
32e56b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Markdown etc LGTM
i am writing a blog on that, we can use that as reference |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Grammatical nit, otherwise LGTM.
content/en/docs/reference/command-line-tools-reference/feature-gates.md
Outdated
Show resolved
Hide resolved
32e56b6
to
ebb2e62
Compare
/lgtm |
LGTM label has been added. Git tree hash: 67f4b71fea87c1e18d9de60a6cf472819b448b41
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/hold
I mentioned a nit; feel free to either tweak that or to unhold and ship the changes as-is.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sftim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ebb2e62
to
ecf1cd1
Compare
/hold cancel |
Thanks @tengqm |
LGTM label has been added. Git tree hash: cf61c229653c0d1c576bee239bf17d5d713d4abb
|
(BTW changes since #32596 (comment) are trivial) |
I wanted to write the second blog in this series, do i need to follow a process or i can go ahead and make a PR ? |
This PR didn't add a blog article. Maybe ask your question in #sig-docs-blog on Slack @krmayankk, and mention the URL of the article that you see as being first in a series. |
PS. Ideally, if you're starting a series of articles, flag that to blog editors when you're looking to publish the first article. |
KEP: kubernetes/enhancements#1010
Upstream: kubernetes/kubernetes#82162