kubeadm: add task page for cluster reconf #32764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
language/en
k8s-ci-robot
added
kind/feature
neolit123
force-pushed
the
1.24-add-steps-for-reconf
branch
2 times, most recently
from
9157020 to
f25dec4
Compare
✅ Deploy Preview for kubernetes-io-main-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for kubernetes-io-main-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
sftim
reviewed
Apr 5, 2022
content/en/docs/tasks/administer-cluster/kubeadm/kubeadm-reconf.md
Outdated
Show resolved
Hide resolved
pacoxu
reviewed
Apr 7, 2022
content/en/docs/tasks/administer-cluster/kubeadm/kubeadm-reconf.md
Outdated
Show resolved
Hide resolved
pacoxu
reviewed
Apr 7, 2022
content/en/docs/tasks/administer-cluster/kubeadm/kubeadm-reconf.md
Outdated
Show resolved
Hide resolved
tengqm
reviewed
Apr 7, 2022
content/en/docs/tasks/administer-cluster/kubeadm/kubeadm-reconf.md
Outdated
Show resolved
Hide resolved
content/en/docs/tasks/administer-cluster/kubeadm/kubeadm-reconf.md
Outdated
Show resolved
Hide resolved
content/en/docs/tasks/administer-cluster/kubeadm/kubeadm-reconf.md
Outdated
Show resolved
Hide resolved
content/en/docs/tasks/administer-cluster/kubeadm/kubeadm-reconf.md
Outdated
Show resolved
Hide resolved
content/en/docs/tasks/administer-cluster/kubeadm/kubeadm-reconf.md
Outdated
Show resolved
Hide resolved
content/en/docs/tasks/administer-cluster/kubeadm/kubeadm-reconf.md
Outdated
Show resolved
Hide resolved
content/en/docs/tasks/administer-cluster/kubeadm/kubeadm-reconf.md
Outdated
Show resolved
Hide resolved
content/en/docs/tasks/administer-cluster/kubeadm/kubeadm-reconf.md
Outdated
Show resolved
Hide resolved
content/en/docs/tasks/administer-cluster/kubeadm/kubeadm-reconf.md
Outdated
Show resolved
Hide resolved
content/en/docs/tasks/administer-cluster/kubeadm/kubeadm-reconf.md
Outdated
Show resolved
Hide resolved
|
thanks for the reviews! will rebase the PR later after i commit a couple of more changes. |
yeah, that seems better.
i can link to the these i guess: |
neolit123
force-pushed
the
1.24-add-steps-for-reconf
branch
from
c38e52c to
3c8d0ea
Compare
|
updated. EDIT: updated again to include link from the "kubeadm upgrade" page and add "what's next" links. |
The new task page outlines steps for reconfiguring a kubeadm cluster and persisting reconfiguration. Link the new page from the existing guides for "customizing components", "creating a cluster", and "kubeadm upgrade". Co-authored-by: Paco Xu <paco.xu@daocloud.io> Co-authored-by: Qiming Teng <tengqm@outlook.com>
neolit123
force-pushed
the
1.24-add-steps-for-reconf
branch
from
3c8d0ea to
931581e
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 8af8d387383de16dec71752b1dfd7734975d3d69
|
pacoxu
approved these changes
Apr 8, 2022
sftim
approved these changes
Apr 8, 2022
| --- | ||
| reviewers: | ||
| - sig-cluster-lifecycle | ||
| title: Reconfiguring a kubeadm cluster |
There was a problem hiding this comment.
capitalization nit:
Suggested change
| title: Reconfiguring a kubeadm cluster | |
| title: Reconfiguring A kubeadm Cluster |
or
Suggested change
| title: Reconfiguring a kubeadm cluster | |
| title: Reconfiguring A Cluster That Was Deployed Using kubeadm |
| Obtain the Pod names: | ||
|
|
||
| ```shell | ||
| kubectl get po -n kube-system | grep coredns |
There was a problem hiding this comment.
In docs, I recommend writing kinds out longhand.
kubectl get pod -n kube-system | grep corednsThe exception is the cheat sheet, where we give folks hint about shortcuts.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pacoxu, sftim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new task page outlines steps for reconfiguring
a kubeadm cluster and persisting reconfiguration.
Link the new page from the existing "customizing components"
guide and the "create cluster" guide.
The idea of the new page is to document what users have to do today to reconf a kubeadm cluster.
We have no automation today, but some kubeadm / kubectl commands can help.
xref kubernetes/kubeadm#970
xref kubernetes/kubeadm#2317
xref kubernetes/kubeadm#2318
preview
https://deploy-preview-32764--kubernetes-io-main-staging.netlify.app/docs/tasks/administer-cluster/kubeadm/kubeadm-reconf/