Add blog article to announce Secret references in NodeExpandVolume #33979

humblec · 2022-05-27T04:17:12Z

Ref# KEP: kubernetes/enhancements#3173
Implementation: kubernetes/kubernetes#105963

Signed-off-by: Humble Chirammal hchiramm@redhat.com

netlify · 2022-05-27T04:30:57Z

✅ Pull request preview available for checking

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`37b77be`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/63173cbba092e800084f6dae
😎 Deploy Preview	https://deploy-preview-33979--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

humblec · 2022-05-27T04:49:35Z

Cc @sftim @xing-yang @zhucan

Sea-n

Here is some questions and format fixes.

content/en/blog/_posts/2022-04-19-csi-nodeexpandsecret.md

sftim

Thanks for getting this draft in early! I hope this feedback helps.

content/en/blog/_posts/2022-04-19-csi-nodeexpandsecret.md

sftim · 2022-05-31T12:58:53Z

/retitle Add blog article to announce Secret references in NodeExpandVolume

sftim

Thanks! Here's a bit more feedback.

content/en/blog/_posts/2022-04-19-csi-nodeexpandsecret.md

bradtopol · 2022-06-01T16:44:13Z

Assigning @sftim since he is already engaged on this.
/assign @sftim

Sea-n · 2022-07-21T18:50:08Z

Hey @humblec,

It's been a while since last update, would you like to address issues in the previous comments so that we can move forward?

humblec · 2022-07-22T08:13:14Z

Hey @humblec,

It's been a while since last update, would you like to address issues in the previous comments so that we can move forward?

Indeed.. Just got busy with other PRs . I have accommodated all the comments from your and @sftim 's review.. thanks a lot!!
Ptal.. 👍

sftim

Thanks. I have a few suggestions for the article to tidy it up.

content/en/blog/_posts/2022-04-19-csi-nodeexpandsecret.md

sftim · 2022-07-22T10:28:05Z

content/en/blog/_posts/2022-04-19-csi-nodeexpandsecret.md

+parameters:
+  csi.storage.k8s.io/node-expand-secret-name: test-secret   # the name of the Secret
+  csi.storage.k8s.io/node-expand-secret-namespace: default  # the namespace that the Secret is in
+provisioner: hostpath.csi.k8s.io


Does this provisioner actually work with NodeExpandVolume secret references?

(if not, maybe make up a fictional provisioner, eg blockstorage.cloudprovider.example?)

yeah.. the hostpath output and logs are from real testing. should be fine. 👍

How does the hostPath provisioner actually use these secrets? If it ignores them, that's maybe not an ideal example.

actually this feature is from the kubernetes csi client to push the secrets to the CSI driver as part of the NodeExpandVolume call.. The hostPath provisioner is a CSI driver who get those as shown in the example.. in that sense, it looks fine to me keep the current version as an example .. @sftim

if really needed I can replace the string hostpath to hostpath-example or something similar.. please let me know wdyt @sftim

Could you explain in a bit more detail (to reviewers, not readers) how a cluster admin works out what they put into test-secret? If I changed the contents of that Secret to have empty strings as the values, would it still work?

If so, then we're not really illustrating things end-to-end. Yes, the feature from the KEP is implemented, but the reader cares about the end-to-end story. They're less interested in seeing an integration test that proves that the secret reference gets to the CSI driver.

Is blockstorage.cloudprovider.example a plausible CSI driver name / reference? If it is, how about using that?

@sftim the nodeExpandSecret follow the same convention or rules of other similar secrets ( for ex: node stage, publish, controller expand) in the SC as described here
https://kubernetes-csi.github.io/docs/secrets-and-credentials-storage-class.html. The secret values will be sent to the CSI driver and if the credentials are correct to connect or perform the requested operation it will work otherwise fail.

Is blockstorage.cloudprovider.example a plausible CSI driver name / reference? If it is, how about using that?

Sure, I have changed the provisioner name to above.. it sound fine to have above as a pluasible CSI driver name..
ptal.. thanks.

content/en/blog/_posts/2022-04-19-csi-nodeexpandsecret.md

humblec · 2022-07-25T04:30:25Z

Cc @xing-yang

humblec · 2022-09-05T14:06:22Z

It would be appreciated if we can get final reviews on this PR !

sftim · 2022-09-05T14:19:15Z

We (blog team) would like a lightweight tech review on this from SIG Storage (optionally also SIG Auth) folks, to make sure there's no obvious technical inaccuracy.
I'm sure that there isn't @humblec but it's nice to have that reassurance.

The article LGTM from a content / writing perspective.

@humblec could you find someone from SIG Storage to check that preview?

humblec · 2022-09-05T15:10:10Z

We (blog team) would like a lightweight tech review on this from SIG Storage (optionally also SIG Auth) folks, to make sure there's no obvious technical inaccuracy. I'm sure that there isn't @humblec but it's nice to have that reassurance.

The article LGTM from a content / writing perspective.

Thanks @sftim 👍

@humblec could you find someone from SIG Storage to check that preview?

Sure, let me find/get review from SIG Storage.
@xing-yang considering you have reviewed this PR, can you please review the preview/final version?

content/en/blog/_posts/2022-09-21-csi-nodeexpandsecret.md

xing-yang · 2022-09-06T00:38:30Z

I added one comment. Otherwise, it looks good to me.

humblec · 2022-09-06T04:08:42Z

I added one comment. Otherwise, it looks good to me.

addressed the same .. Thanks

sftim

That last fix wasn't right, I'm afraid.

content/en/blog/_posts/2022-09-21-csi-nodeexpandsecret.md

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>

humblec · 2022-09-06T12:29:08Z

That last fix wasn't right, I'm afraid.

I have reformatted as suggested.. thanks 👍

sftim · 2022-09-07T13:56:16Z

Thanks

/lgtm
/approve

k8s-ci-robot · 2022-09-07T13:56:26Z

LGTM label has been added.

Git tree hash: b51ee65e1affc5d78012fc27552d7b2b78c241cb

k8s-ci-robot · 2022-09-07T13:56:38Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~content/en/blog/OWNERS~~ [sftim]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 27, 2022

k8s-ci-robot requested a review from onlydole May 27, 2022 04:17

k8s-ci-robot added the area/blog Issues or PRs related to the Kubernetes Blog subproject label May 27, 2022

k8s-ci-robot requested a review from sftim May 27, 2022 04:17

k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels May 27, 2022

humblec force-pushed the node-expand-1.25 branch from 326678f to db10c6f Compare May 27, 2022 04:48

Sea-n reviewed May 27, 2022

View reviewed changes

sftim previously requested changes May 29, 2022

View reviewed changes

humblec force-pushed the node-expand-1.25 branch from db10c6f to 988526b Compare May 31, 2022 12:57

k8s-ci-robot changed the title ~~Add csi nodeexpandsecret blog article~~ Add blog article to announce Secret references in NodeExpandVolume May 31, 2022

humblec force-pushed the node-expand-1.25 branch 2 times, most recently from e65390f to ce3e5f2 Compare May 31, 2022 13:06

sftim reviewed May 31, 2022

View reviewed changes

k8s-ci-robot assigned sftim Jun 1, 2022

humblec force-pushed the node-expand-1.25 branch from ce3e5f2 to 052f17f Compare July 22, 2022 08:11

humblec requested review from sftim and Sea-n July 22, 2022 08:15

sftim reviewed Jul 22, 2022

View reviewed changes

humblec force-pushed the node-expand-1.25 branch from 052f17f to 6778b27 Compare July 22, 2022 10:51

humblec requested a review from sftim July 22, 2022 10:52

humblec force-pushed the node-expand-1.25 branch from 6778b27 to 56df3f0 Compare July 25, 2022 04:25

humblec requested review from sftim and Sea-n and removed request for sftim August 31, 2022 07:36

humblec force-pushed the node-expand-1.25 branch from 2c91269 to 40ae12a Compare August 31, 2022 07:44

humblec requested review from sftim and removed request for Sea-n September 2, 2022 04:38

humblec requested review from xing-yang and Sea-n and removed request for sftim, xing-yang and Sea-n September 5, 2022 15:36

xing-yang reviewed Sep 6, 2022

View reviewed changes

content/en/blog/_posts/2022-09-21-csi-nodeexpandsecret.md Outdated Show resolved Hide resolved

humblec force-pushed the node-expand-1.25 branch from 40ae12a to 7d4e347 Compare September 6, 2022 04:07

humblec requested a review from xing-yang September 6, 2022 04:33

sftim reviewed Sep 6, 2022

View reviewed changes

content/en/blog/_posts/2022-09-21-csi-nodeexpandsecret.md Outdated Show resolved Hide resolved

Add csi nodeexpandsecret blog article

37b77be

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>

humblec force-pushed the node-expand-1.25 branch from 7d4e347 to 37b77be Compare September 6, 2022 12:27

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 7, 2022

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2022

k8s-ci-robot merged commit 4b43dac into kubernetes:main Sep 7, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add blog article to announce Secret references in NodeExpandVolume #33979

Add blog article to announce Secret references in NodeExpandVolume #33979

humblec commented May 27, 2022

netlify bot commented May 27, 2022 •

edited

Loading

humblec commented May 27, 2022

Sea-n left a comment

sftim left a comment

sftim commented May 31, 2022

sftim left a comment

bradtopol commented Jun 1, 2022

Sea-n commented Jul 21, 2022

humblec commented Jul 22, 2022

sftim left a comment

sftim Jul 22, 2022

humblec Jul 22, 2022

sftim Jul 22, 2022

humblec Jul 22, 2022

humblec Jul 22, 2022

sftim Jul 22, 2022

humblec Jul 25, 2022 •

edited

Loading

humblec commented Jul 25, 2022

humblec commented Sep 5, 2022

sftim commented Sep 5, 2022

humblec commented Sep 5, 2022

xing-yang commented Sep 6, 2022

humblec commented Sep 6, 2022

sftim left a comment

humblec commented Sep 6, 2022

sftim commented Sep 7, 2022

k8s-ci-robot commented Sep 7, 2022

k8s-ci-robot commented Sep 7, 2022

Add blog article to announce Secret references in NodeExpandVolume #33979

Add blog article to announce Secret references in NodeExpandVolume #33979

Conversation

humblec commented May 27, 2022

netlify bot commented May 27, 2022 • edited Loading

✅ Pull request preview available for checking

humblec commented May 27, 2022

Sea-n left a comment

Choose a reason for hiding this comment

sftim left a comment

Choose a reason for hiding this comment

sftim commented May 31, 2022

sftim left a comment

Choose a reason for hiding this comment

bradtopol commented Jun 1, 2022

Sea-n commented Jul 21, 2022

humblec commented Jul 22, 2022

sftim left a comment

Choose a reason for hiding this comment

sftim Jul 22, 2022

Choose a reason for hiding this comment

humblec Jul 22, 2022

Choose a reason for hiding this comment

sftim Jul 22, 2022

Choose a reason for hiding this comment

humblec Jul 22, 2022

Choose a reason for hiding this comment

humblec Jul 22, 2022

Choose a reason for hiding this comment

sftim Jul 22, 2022

Choose a reason for hiding this comment

humblec Jul 25, 2022 • edited Loading

Choose a reason for hiding this comment

humblec commented Jul 25, 2022

humblec commented Sep 5, 2022

sftim commented Sep 5, 2022

humblec commented Sep 5, 2022

xing-yang commented Sep 6, 2022

humblec commented Sep 6, 2022

sftim left a comment

Choose a reason for hiding this comment

humblec commented Sep 6, 2022

sftim commented Sep 7, 2022

k8s-ci-robot commented Sep 7, 2022

k8s-ci-robot commented Sep 7, 2022

netlify bot commented May 27, 2022 •

edited

Loading

humblec Jul 25, 2022 •

edited

Loading