Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add blog about CSI Inline Volumes GA #35511

Merged
merged 5 commits into from
Aug 24, 2022
Merged

Add blog about CSI Inline Volumes GA #35511

merged 5 commits into from
Aug 24, 2022

Conversation

dobsonj
Copy link
Member

@dobsonj dobsonj commented Jul 28, 2022 •
edited
Loading

@netlify
Copy link

netlify bot commented Jul 28, 2022

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 58f029a
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/62e2b15cd7c9c50008a72d42

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 28, 2022
@k8s-ci-robot k8s-ci-robot added area/blog Issues or PRs related to the Kubernetes Blog subproject language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jul 28, 2022
@dobsonj dobsonj mentioned this pull request Jul 28, 2022
Closed
@reylejano
Copy link
Member

reylejano commented Aug 3, 2022 •
edited
Loading

/hold
hold for the related enhancement not making the 1.25 code freeze
see kubernetes/enhancements#596 (comment)

@dobsonj
Copy link
Member Author

dobsonj commented Aug 5, 2022

/hold
hold for the related enhancement not making the 1.25 code freeze
see kubernetes/enhancements#596 (comment)

Hi @reylejano , an exception was approved today and the k/k PR merged for 1.25

@katcosgrove
Copy link
Contributor

Hi from the Comms team! Just a reminder that the Ready to Review deadline for feature blogs is Tuesday, August 16. You will also be assigned a publication date post-release. Is there anything we can do to help you right now?

@xing-yang
Copy link
Contributor

Blog should be submitted to main, not dev-1.25 branch.

@AnaMMedina21
Copy link
Member

Hi from Comms team!
The "Ready to Review" deadline for feature blogs is TODAY - Tuesday, August 16, do you have an updated PR?

@dobsonj dobsonj changed the base branch from dev-1.25 to main August 16, 2022 20:11
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 16, 2022
@dobsonj dobsonj changed the title WIP: Add blog about CSI Inline Volumes GA Add blog about CSI Inline Volumes GA Aug 16, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 16, 2022
@dobsonj
Copy link
Member Author

dobsonj commented Aug 16, 2022

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 16, 2022
@netlify
Copy link

netlify bot commented Aug 16, 2022

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 110aa31
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62fbfa089e06a00009a4ee53
😎 Deploy Preview https://deploy-preview-35511--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 16, 2022 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit e0c9f43
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/630599fd68f0e9000a3e664a
😎 Deploy Preview https://deploy-preview-35511--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@dobsonj
Copy link
Member Author

dobsonj commented Aug 16, 2022

Hi from Comms team! The "Ready to Review" deadline for feature blogs is TODAY - Tuesday, August 16, do you have an updated PR?

Hi @AnaMMedina21 @xing-yang , sorry for the last minute changes, I just pushed the updated content and rebased on the main branch. Thanks!

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 19, 2022
kfox1111
kfox1111 reviewed Aug 22, 2022
View reviewed changes
content/en/blog/_posts/2022-08-29-csi-inline-volumes-ga.md Outdated
volumes:
- name: my-csi-volume
csi:
driver: hostpath.csi.k8s.io
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Host path is kind of a bad example IMO. doesn't show anything it can do beyond what k8s natively can do.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to pick an in-project CSI driver if we can, but I agree: hostPath / hostpath.csi.k8s.io is a bit boring.

How about Secrets Store?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image populator is still in project. secretstore would be a good one too though.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback, I updated the example to use the secret store csi driver.

@sftim sftim mentioned this pull request Aug 22, 2022
Closed
9 tasks
sftim
sftim reviewed Aug 22, 2022
View reviewed changes
content/en/blog/_posts/2022-08-29-csi-inline-volumes-ga.md Outdated
volumes:
- name: my-csi-volume
csi:
driver: hostpath.csi.k8s.io
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to pick an in-project CSI driver if we can, but I agree: hostPath / hostpath.csi.k8s.io is a bit boring.

How about Secrets Store?

content/en/blog/_posts/2022-08-29-csi-inline-volumes-ga.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2022-08-29-csi-inline-volumes-ga.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2022-08-29-csi-inline-volumes-ga.md Outdated Show resolved Hide resolved
@sftim
Copy link
Contributor

sftim commented Aug 22, 2022

/lgtm
/approve

More fixes are welcome, but not required.

/hold
OK to unhold this once v1.25 is actually released.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 22, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 22, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2cb3ff9987f5a2aeae108e5c3d4cdf00d782b443

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Aug 22, 2022
@dobsonj @sftim
CSI Inline Volumes: apply suggestions from code review
f89fffd 
Co-authored-by: Tim Bannister <tim@scalefactory.com>
@mehabhalodiya
Copy link
Contributor

Unholding per #35511 (comment)

/unhold
/lgtm

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 24, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 24, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e4b7239ed0c72b3bb6d81326dd859456dea090d7

@k8s-ci-robot k8s-ci-robot merged commit 7a7a165 into kubernetes:main Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfox1111 kfox1111 kfox1111 left review comments

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

@onlydole onlydole Awaiting requested review from onlydole

@sftim sftim Awaiting requested review from sftim

@xing-yang xing-yang Awaiting requested review from xing-yang

Assignees

@xing-yang xing-yang

@sftim sftim

@mehabhalodiya mehabhalodiya

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG Docs Blog Project Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@dobsonj @reylejano @katcosgrove @xing-yang @AnaMMedina21 @sftim @k8s-ci-robot @mehabhalodiya @kfox1111