Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Pod-based example for NFS volumes #36534

Merged
merged 2 commits into from
Sep 20, 2022

Conversation

mac-chaffee
Copy link
Contributor

The existing documentation for NFS volumes was missing an example for mounting NFS volumes directly in Pods. The linked example only shows how to mount NFS volumes via PersistentVolumes.

I've added a Pod-based example.

I've also added a note about how you cannot specify mount options inside a Pod spec (like you can in a PersistentVolume) and listed some alternatives since there is no plan to support a new mountOptions setting in Pods: https://github.com/kubernetes/design-proposals-archive/blob/main/storage/mount-options.md#preventing-users-from-specifying-mount-options-in-inline-volume-specs-of-pod

Other relevant issues:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. language/en Issues or PRs related to English language labels Sep 2, 2022
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Sep 2, 2022
@netlify
Copy link

netlify bot commented Sep 2, 2022

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 5f58dea
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/631fbada1df33d0008e55317
😎 Deploy Preview https://deploy-preview-36534--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@divya-mohan0209
Copy link
Contributor

/sig storage

@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Sep 3, 2022
@divya-mohan0209
Copy link
Contributor

@kubernetes/sig-storage-pr-reviews: Please could you check this from a technical standpoint & provide signoff/suggestions?

@mac-chaffee mac-chaffee requested review from jsafrane and removed request for thockin and saad-ali September 12, 2022 23:04
@jsafrane
Copy link
Member

lgtm from sig-storage side

Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2022
@sftim
Copy link
Contributor

sftim commented Sep 20, 2022

/lgtm

for SIG Docs

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 20, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: cf113da7e1ba83034bc751c66383eb8c2ce6728a

@k8s-ci-robot k8s-ci-robot merged commit 3af9c83 into kubernetes:main Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants