-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Pod-based example for NFS volumes #36534
Conversation
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
/sig storage |
@kubernetes/sig-storage-pr-reviews: Please could you check this from a technical standpoint & provide signoff/suggestions? |
lgtm from sig-storage side |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sftim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm for SIG Docs |
LGTM label has been added. Git tree hash: cf113da7e1ba83034bc751c66383eb8c2ce6728a
|
The existing documentation for NFS volumes was missing an example for mounting NFS volumes directly in Pods. The linked example only shows how to mount NFS volumes via PersistentVolumes.
I've added a Pod-based example.
I've also added a note about how you cannot specify mount options inside a Pod spec (like you can in a PersistentVolume) and listed some alternatives since there is no plan to support a new
mountOptions
setting in Pods: https://github.com/kubernetes/design-proposals-archive/blob/main/storage/mount-options.md#preventing-users-from-specifying-mount-options-in-inline-volume-specs-of-podOther relevant issues: