-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link from Policies concept to NetworkPolicy page #36670
Link from Policies concept to NetworkPolicy page #36670
Conversation
Helps with #14770 |
✅ Pull request preview available for checking
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
3a9de3a
to
22ec0c1
Compare
/lgtm |
LGTM label has been added. Git tree hash: 091511d56dcb4f28233a32f3b8c3b31699ffc21c
|
|
||
{{< note >}} | ||
See [Network Policies](/docs/concepts/services-networking/network-policies/) | ||
for documentation about NetworkPolicy in Kubernetes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sftim. Is there a good reason to include a link to the Network Policies section from this index page? Why does this information need to be in a note?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If someone is looking for network policies, they might look for it in the Policies section, but it's actually in the Networking section. This note is to help people who looked in Policies find the thing that they are looking for.
Maybe we have a different mechanism to add it into the navigation itself; if we do, I don't know about that other section.
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kbhawkey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Split out from #30817
Link from Policies concept to Network Policies page. [preview]