Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link from Policies concept to NetworkPolicy page #36670

Merged

Conversation

sftim
Copy link
Contributor

@sftim sftim commented Sep 7, 2022

Split out from #30817

Link from Policies concept to Network Policies page. [preview]

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 7, 2022
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Sep 7, 2022
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 7, 2022
@sftim
Copy link
Contributor Author

sftim commented Sep 7, 2022

Helps with #14770

@netlify
Copy link

netlify bot commented Sep 8, 2022

Pull request preview available for checking

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6319cd81d6b11405c7068350
😎 Deploy Preview https://deploy-preview-36670--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Sep 8, 2022

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 22ec0c1
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/631b01b2a3470e00081ffc81
😎 Deploy Preview https://deploy-preview-36670--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sftim sftim force-pushed the 20220110_hyperlink_network_policies branch from 3a9de3a to 22ec0c1 Compare September 9, 2022 09:04
@mtardy
Copy link
Member

mtardy commented Sep 19, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 19, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 091511d56dcb4f28233a32f3b8c3b31699ffc21c


{{< note >}}
See [Network Policies](/docs/concepts/services-networking/network-policies/)
for documentation about NetworkPolicy in Kubernetes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sftim. Is there a good reason to include a link to the Network Policies section from this index page? Why does this information need to be in a note?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If someone is looking for network policies, they might look for it in the Policies section, but it's actually in the Networking section. This note is to help people who looked in Policies find the thing that they are looking for.

Maybe we have a different mechanism to add it into the navigation itself; if we do, I don't know about that other section.

@kbhawkey
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kbhawkey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 21, 2022
@k8s-ci-robot k8s-ci-robot merged commit c2c4f5a into kubernetes:main Sep 21, 2022
@sftim sftim deleted the 20220110_hyperlink_network_policies branch November 5, 2022 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants