Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganize “Services, Load Balancing, and Networking” concept #36671

Merged
merged 1 commit into from
Sep 22, 2022
Merged

Reorganize “Services, Load Balancing, and Networking” concept #36671

merged 1 commit into from
Sep 22, 2022

Conversation

sftim
Copy link
Contributor

@sftim sftim commented Sep 7, 2022

Split out from #30817

  • Add descriptions to pages
  • Change page weights - the aim is to have the concepts flow in an order that makes better sense to the reader

@sftim
Reorganize "Services, Load Balancing, and Networking" concept
3970b2b 
- Add descriptions
- Change page weights
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Sep 7, 2022
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 7, 2022
@sftim sftim mentioned this pull request Sep 7, 2022
Closed
@sftim
Copy link
Contributor Author

sftim commented Sep 7, 2022

Helps with #14770

@sftim sftim changed the title Reorganize "Services, Load Balancing, and Networking" concept Reorganize “Services, Load Balancing, and Networking” concept Sep 7, 2022
@netlify
Copy link

netlify bot commented Sep 7, 2022

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 3970b2b
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6318fb25c1121200095d0b77
😎 Deploy Preview https://deploy-preview-36671--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@tengqm
Copy link
Contributor

tengqm commented Sep 8, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 8, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1dbe323b9789f7c64c332f181f323060d1f45966

Sea-n
Sea-n reviewed Sep 15, 2022
View reviewed changes
Copy link
Member

@Sea-n Sea-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kbhawkey
Copy link
Contributor

kbhawkey commented Sep 22, 2022 •
edited
Loading

Page previews:
https://deploy-preview-36671--kubernetes-io-main-staging.netlify.app/docs/concepts/services-networking/
https://deploy-preview-36671--kubernetes-io-main-staging.netlify.app/docs/concepts/services-networking/connect-applications-service/

@kbhawkey
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kbhawkey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2022
@k8s-ci-robot k8s-ci-robot merged commit d29b547 into kubernetes:main Sep 22, 2022
@windsonsea windsonsea mentioned this pull request Sep 22, 2022
Merged
@sftim sftim deleted the 20220110_reorganize_services_load_balancing_networking branch October 11, 2022 16:51
@sftim
Copy link
Contributor Author

sftim commented Oct 24, 2022

Also see #37494

@chrismetz09 chrismetz09 mentioned this pull request Nov 1, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sea-n Sea-n Sea-n left review comments

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@caseydavenport caseydavenport Awaiting requested review from caseydavenport

Assignees

@tengqm tengqm

@Sea-n Sea-n

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sftim @tengqm @k8s-ci-robot @kbhawkey @Sea-n